[PATCH] omap3-n900: enable autofocus

[PATCH] omap3-n900: enable autofocus

[Pavel Machek]

Connect auto-focus coil to the camera sensor, so that it can be used
by camera applications.

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 669c51c..59cc743 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -778,6 +778,8 @@
 
 		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
 
+		lens-focus = <&ad5820>;
+
 		port {
 			csi_cam1: endpoint {
 				bus-type = <3>; /* CCP2 */

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171112/2c191d7b/attachment.sig>

[PATCH] omap3-n900: enable autofocus

[Pali Rohár]

On Sunday 12 November 2017 12:25:29 Pavel Machek wrote:
> 
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

Acked-by: Pali Roh?r <pali.rohar@gmail.com>

> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 669c51c..59cc743 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -778,6 +778,8 @@
>  
>  		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
>  
> +		lens-focus = <&ad5820>;
> +
>  		port {
>  			csi_cam1: endpoint {
>  				bus-type = <3>; /* CCP2 */
> 

-- 
Pali Roh?r
pali.rohar at gmail.com

[PATCH] omap3-n900: enable autofocus

[Sebastian Reichel]

Hi,

On Sun, Nov 12, 2017 at 12:25:29PM +0100, Pavel Machek wrote:
> 
> Connect auto-focus coil to the camera sensor, so that it can be used
> by camera applications.
> 
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

I think you should replace auto-focus with lens-focus. This is not
automatic. Otherwise:

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index 669c51c..59cc743 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -778,6 +778,8 @@
>  
>  		reset-gpio = <&gpio4 6 GPIO_ACTIVE_HIGH>; /* 102 */
>  
> +		lens-focus = <&ad5820>;
> +
>  		port {
>  			csi_cam1: endpoint {
>  				bus-type = <3>; /* CCP2 */
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171112/8566b3fa/attachment.sig>

[PATCH] omap3-n900: enable autofocus

[Pavel Machek]

On Sun 2017-11-12 15:29:18, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, Nov 12, 2017 at 12:25:29PM +0100, Pavel Machek wrote:
> > 
> > Connect auto-focus coil to the camera sensor, so that it can be used
> > by camera applications.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> 
> I think you should replace auto-focus with lens-focus. This is not
> automatic. Otherwise:

You are right... althrough the lens is really meant for auto-focus.

Anyway, I can send the updated patch if neccessary.

Best regards,
								Pavel 
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171113/202e3be5/attachment.sig>