From mboxrd@z Thu Jan  1 00:00:00 1970
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
Date: Wed, 15 Nov 2017 09:34:10 +0900
Subject: [RFC] kvm: vgic: are these warnings wrong?
In-Reply-To: <5c77ed5c-3b57-f9ba-b24d-f54729bc6a59@arm.com>
References: <20171114064750.GB29552@linaro.org>
 <5c77ed5c-3b57-f9ba-b24d-f54729bc6a59@arm.com>
Message-ID: <20171115003408.GE29552@linaro.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Tue, Nov 14, 2017 at 09:07:46AM +0000, Marc Zyngier wrote:
> On 14/11/17 06:47, AKASHI Takahiro wrote:
> > Hi Marc,
> > 
> > I've just run a static analyzer to v4.14.
> > While most of warnings/errors are false-positive, as you can easily imagine,
> > there are something dubious. Can you please check ones below?
> > 
> > virt/kvm/arm/vgic/vgic-v3.c:352 vgic_v3_save_pending_tables() error: uninitialized symbol 'val'.
> > virt/kvm/arm/vgic/vgic-its.c:424 its_sync_lpi_pending_table() error: uninitialized symbol 'pendmask'.
> > virt/kvm/arm/vgic/vgic-its.c:779 vgic_its_alloc_collection() error: potential null dereference 'collection'.  (kzalloc returns null)
> > virt/kvm/arm/vgic/vgic-irqfd.c:115 kvm_vgic_setup_default_irq_routing() warn: double check that we're allocating correct size: 48 vs 64
> > 
> > # I believe that the messages here are self-describing.
> 
> Hi Takahiro,
> 
> All of these are pretty good findings... Out of curiosity, what is the
> tool you've been using?

smatch!
https://blogs.oracle.com/linuxkernel/smatch-static-analysis-tool-overview,-by-dan-carpenter

> Many thanks for reporting these bugs.

I want to find more bugs with such tools :) Just kidding.

-Takahiro AKASHI

> 	M.
> -- 
> Jazz is not dead. It just smells funny...