From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()
Date: Wed, 15 Nov 2017 16:03:31 +0100 [thread overview]
Message-ID: <20171115150331.GA29642@lunn.ch> (raw)
In-Reply-To: <01be0b9e-3d6c-bd1e-6b92-e2274ffeea5a@sigmadesigns.com>
On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote:
> On 15/11/2017 15:17, Andrew Lunn wrote:
>
> > nb8800_link_reconfigure() can be called whenever the link to the peer
> > changes. auto-neg may happen later because the cable was not plugged
> > in until later, etc.
>
> Hello Andrew,
>
> AFAICS, Mans was right: trying to toggle the flow control bit when
> the RX DMA bit is already set "breaks" the HW (ping times out).
>
> Thus, I will drop patch 2/4.
O.K. Thanks for testing this.
> In our local branch, I have completely disabled flow control support,
> so I don't have to worry about this problem.
That is an interesting statement. You now know there is an issue here,
your solution is to fix your private branch and leave mainline as is.
Andrew
next prev parent reply other threads:[~2017-11-15 15:03 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 10:53 [PATCH v3 0/4] Various nb8800 tweaks Marc Gonzalez
2017-11-14 10:54 ` [PATCH v3 1/4] net: nb8800: Drop generic support Marc Gonzalez
2017-11-14 12:37 ` Måns Rullgård
2017-11-14 12:47 ` Marc Gonzalez
2017-11-14 13:03 ` Måns Rullgård
2017-11-14 10:55 ` [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config() Marc Gonzalez
2017-11-14 12:38 ` Måns Rullgård
2017-11-14 12:56 ` Marc Gonzalez
2017-11-14 13:22 ` Måns Rullgård
2017-11-15 10:53 ` Marc Gonzalez
2017-11-15 14:17 ` Andrew Lunn
2017-11-15 14:33 ` Marc Gonzalez
2017-11-15 15:03 ` Andrew Lunn [this message]
2017-11-15 15:19 ` Marc Gonzalez
2017-11-15 15:36 ` Måns Rullgård
2017-11-15 21:12 ` Andrew Lunn
2017-11-14 10:56 ` [PATCH v3 3/4] net: nb8800: Move HW init to ndo_open() Marc Gonzalez
2017-11-14 12:40 ` Måns Rullgård
2017-11-14 13:26 ` Marc Gonzalez
2017-11-14 13:54 ` Måns Rullgård
2017-11-14 16:41 ` Marc Gonzalez
2017-11-14 16:55 ` Måns Rullgård
2017-11-14 17:07 ` Marc Gonzalez
2017-11-15 14:58 ` Marc Gonzalez
2017-11-15 15:11 ` Måns Rullgård
2017-11-15 16:15 ` Marc Gonzalez
2017-11-16 12:21 ` Marc Gonzalez
2017-11-16 16:23 ` Andrew Lunn
2017-11-16 16:52 ` Marc Gonzalez
2017-11-14 12:04 ` [PATCH v3 4/4] net: nb8800: Add support for suspend/resume Marc Gonzalez
2017-11-14 13:02 ` Måns Rullgård
2017-11-14 14:22 ` Marc Gonzalez
2017-11-14 16:31 ` Andrew Lunn
2017-11-14 17:08 ` Marc Gonzalez
2017-11-14 17:33 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115150331.GA29642@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).