From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/10 v2] Input: serio: Fix platform_get_irq's error checking
Date: Sat, 18 Nov 2017 08:20:54 +0000 [thread overview]
Message-ID: <20171118082054.GA31757@n2100.armlinux.org.uk> (raw)
In-Reply-To: <8104ffc3b7bedee525c0cba9144cedaf04087fd4.1510951446.git.arvind.yadav.cs@gmail.com>
On Sat, Nov 18, 2017 at 02:28:50AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct
IRQ 0 is not a valid interrupt. The correct test here is <= 0.
Please rework your patches for this.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync@8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-11-18 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 20:58 [PATCH 1/3 v2] Input: omap4-keypad: Fix platform_get_irq's error checking Arvind Yadav
2017-11-17 20:58 ` [PATCH 2/3 v2] Input: twl4030_keypad: " Arvind Yadav
2017-11-18 8:20 ` Russell King - ARM Linux
2017-11-17 20:58 ` [PATCH 4/10 v2] Input: serio: " Arvind Yadav
2017-11-18 8:20 ` Russell King - ARM Linux [this message]
2017-11-18 8:20 ` [PATCH 1/3 v2] Input: omap4-keypad: " Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171118082054.GA31757@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).