* [PATCH] ARM: dts: exynos: correct trats2 panel reset line
@ 2017-11-21 11:24 ` Simon Shields
2017-11-21 15:06 ` Marek Szyprowski
0 siblings, 1 reply; 3+ messages in thread
From: Simon Shields @ 2017-11-21 11:24 UTC (permalink / raw)
To: linux-arm-kernel
trats2 uses gpf2-1 as the panel reset GPIO. gpy4-5 was only used
on early revisions of the board.
Fixes: 420ae8451a22 ("ARM: dts: exynos4412-trats2: add panel node")
Signed-off-by: Simon Shields <simon@lineageos.org>
---
arch/arm/boot/dts/exynos4412-trats2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 220cdf109405..9f4672ba9943 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -454,7 +454,7 @@
reg = <0>;
vdd3-supply = <&lcd_vdd3_reg>;
vci-supply = <&ldo25_reg>;
- reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
power-on-delay= <50>;
reset-delay = <100>;
init-delay = <100>;
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: exynos: correct trats2 panel reset line
2017-11-21 11:24 ` [PATCH] ARM: dts: exynos: correct trats2 panel reset line Simon Shields
@ 2017-11-21 15:06 ` Marek Szyprowski
2017-11-27 18:12 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Marek Szyprowski @ 2017-11-21 15:06 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On 2017-11-21 12:24, Simon Shields wrote:
> trats2 uses gpf2-1 as the panel reset GPIO. gpy4-5 was only used
> on early revisions of the board.
>
> Fixes: 420ae8451a22 ("ARM: dts: exynos4412-trats2: add panel node")
> Signed-off-by: Simon Shields <simon@lineageos.org>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
It looks that this has been accidentally copy/pasted from the previous
dts used for early version of the development board. I've checked the
Trats2 schematic and indeed gpf2-1 is the correct pin for panel reset
line.
> ---
> arch/arm/boot/dts/exynos4412-trats2.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
> index 220cdf109405..9f4672ba9943 100644
> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
> @@ -454,7 +454,7 @@
> reg = <0>;
> vdd3-supply = <&lcd_vdd3_reg>;
> vci-supply = <&ldo25_reg>;
> - reset-gpios = <&gpy4 5 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpf2 1 GPIO_ACTIVE_HIGH>;
> power-on-delay= <50>;
> reset-delay = <100>;
> init-delay = <100>;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] ARM: dts: exynos: correct trats2 panel reset line
2017-11-21 15:06 ` Marek Szyprowski
@ 2017-11-27 18:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2017-11-27 18:12 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 21, 2017 at 04:06:38PM +0100, Marek Szyprowski wrote:
> Hi Simon,
>
> On 2017-11-21 12:24, Simon Shields wrote:
> > trats2 uses gpf2-1 as the panel reset GPIO. gpy4-5 was only used
> > on early revisions of the board.
> >
> > Fixes: 420ae8451a22 ("ARM: dts: exynos4412-trats2: add panel node")
> > Signed-off-by: Simon Shields <simon@lineageos.org>
>
> Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> It looks that this has been accidentally copy/pasted from the previous
> dts used for early version of the development board. I've checked the
> Trats2 schematic and indeed gpf2-1 is the correct pin for panel reset
> line.
Thanks for testing.
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-27 18:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171121112435epcas4p25f529481eebd076f0fde78c500b04395@epcas4p2.samsung.com>
2017-11-21 11:24 ` [PATCH] ARM: dts: exynos: correct trats2 panel reset line Simon Shields
2017-11-21 15:06 ` Marek Szyprowski
2017-11-27 18:12 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).