From: me@tobin.cc (Tobin C. Harding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] staging: fsl-mc: fix mc-portal to use u32 type
Date: Wed, 22 Nov 2017 11:21:16 +1100 [thread overview]
Message-ID: <20171122002116.GV7472@eros> (raw)
In-Reply-To: <1511240723-24829-1-git-send-email-Bharat.Bhushan@nxp.com>
On Tue, Nov 21, 2017 at 10:35:23AM +0530, Bharat Bhushan wrote:
> According to MC APIs, size of mc-portal in 32bit.
> Also fsl_create_mc_io() storing 32 bit mc-portal size.
> " mc_io->portal_size = mc_portal_size;"
> While "mc_io->portal_size" is u16 type and
> "mc_portal_size" is u32 type.
>
> This patches changes mc_io->portal_size from u16 to u32
You may like to read Documentation/process/submitting-patches.rst for
tips or writing the git commit log.
> Signed-off-by: Bharat Bhushan <Bharat.Bhushan@nxp.com>
> ---
Include here what changed from v1 -> v2
> drivers/staging/fsl-mc/include/mc-sys.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fsl-mc/include/mc-sys.h b/drivers/staging/fsl-mc/include/mc-sys.h
> index dca7f90..11d4367 100644
> --- a/drivers/staging/fsl-mc/include/mc-sys.h
> +++ b/drivers/staging/fsl-mc/include/mc-sys.h
> @@ -75,7 +75,7 @@
> struct fsl_mc_io {
> struct device *dev;
> u16 flags;
> - u16 portal_size;
> + u32 portal_size;
> phys_addr_t portal_phys_addr;
> void __iomem *portal_virt_addr;
> struct fsl_mc_device *dpmcp_dev;
I was not able to apply this patch to either Greg's staging tree or
Linus' mainline.
Does this change clear any Sparse warnings? If so you may like to note
that in the commit log.
Hope this helps,
Tobin.
prev parent reply other threads:[~2017-11-22 0:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 5:05 [PATCH v2] staging: fsl-mc: fix mc-portal to use u32 type Bharat Bhushan
2017-11-22 0:21 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171122002116.GV7472@eros \
--to=me@tobin.cc \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).