From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 28 Nov 2017 06:55:21 -0800 Subject: [PATCH] ARM: OMAP2+: Missing error code in omap_device_build() In-Reply-To: <20171114060648.frwveus2pjpx5idw@mwanda> References: <20171114060648.frwveus2pjpx5idw@mwanda> Message-ID: <20171128145521.GX28152@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Dan Carpenter [171113 22:10]: > We need to set the error code if omap_device_alloc() fails. > > Signed-off-by: Dan Carpenter > > diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c > index 184acd95c216..f0388058b7da 100644 > --- a/arch/arm/mach-omap2/omap_device.c > +++ b/arch/arm/mach-omap2/omap_device.c > @@ -514,8 +514,10 @@ struct platform_device __init *omap_device_build(const char *pdev_name, > goto odbs_exit1; > > od = omap_device_alloc(pdev, &oh, 1); > - if (IS_ERR(od)) > + if (IS_ERR(od)) { > + ret = PTR_ERR(od); > goto odbs_exit1; > + } > > ret = platform_device_add_data(pdev, pdata, pdata_len); > if (ret) Applying into omap-for-v4.15/fixes thanks. Tony