linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: liviu.dudau@arm.com (Liviu Dudau)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO()
Date: Tue, 28 Nov 2017 15:53:52 +0000	[thread overview]
Message-ID: <20171128155352.GS1119@e110455-lin.cambridge.arm.com> (raw)
In-Reply-To: <1511882443-5851-1-git-send-email-gomonovych@gmail.com>

On Tue, Nov 28, 2017 at 04:20:43PM +0100, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/misc/vexpress-syscfg.c:273:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

Acked-by: Liviu Dudau <liviu.dudau@arm.com>

> ---
>  drivers/misc/vexpress-syscfg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c
> index 2cde80c7bb93..9eea30f54fd6 100644
> --- a/drivers/misc/vexpress-syscfg.c
> +++ b/drivers/misc/vexpress-syscfg.c
> @@ -270,10 +270,8 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
>  	/* Must use dev.parent (MFD), as that's where DT phandle points at... */
>  	bridge = vexpress_config_bridge_register(pdev->dev.parent,
>  			&vexpress_syscfg_bridge_ops, syscfg);
> -	if (IS_ERR(bridge))
> -		return PTR_ERR(bridge);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(bridge);
>  }
>  
>  static const struct platform_device_id vexpress_syscfg_id_table[] = {
> -- 
> 1.9.1
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ?\_(?)_/?

      reply	other threads:[~2017-11-28 15:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 15:20 [PATCH] misc: vexpress: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 15:53 ` Liviu Dudau [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128155352.GS1119@e110455-lin.cambridge.arm.com \
    --to=liviu.dudau@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).