linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 2/4] ACPI / bus: introduce acpi_device_get_match_data() function
Date: Wed, 29 Nov 2017 19:25:36 +0530	[thread overview]
Message-ID: <20171129135536.GD32417@localhost> (raw)
In-Reply-To: <1605519.pfaIp4IsxJ@aspire.rjw.lan>

On Sun, Nov 12, 2017 at 01:14:12AM +0100, Rafael J. Wysocki wrote:
> On Friday, November 10, 2017 3:35:41 AM CET Sinan Kaya wrote:
> > +linux-acpi at vger.kernel.org, +Rafael
> 
> Thanks!
> 
> > On 11/9/2017 9:32 PM, Sinan Kaya wrote:
> > > OF has of_device_get_match_data() function to extract driver specific data
> > > structure. Add a similar function for ACPI.
> > > 
> > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> > > ---
> > >  drivers/acpi/bus.c   | 12 ++++++++++++
> > >  include/linux/acpi.h |  6 ++++++
> > >  2 files changed, 18 insertions(+)
> > > 
> > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> > > index 4d0979e..da29c10 100644
> > > --- a/drivers/acpi/bus.c
> > > +++ b/drivers/acpi/bus.c
> > > @@ -785,6 +785,18 @@ const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids,
> > >  }
> > >  EXPORT_SYMBOL_GPL(acpi_match_device);
> > >  
> > > +void *acpi_device_get_match_data(const struct device *dev)
> > > +{
> > > +	const struct acpi_device_id *match;
> > > +
> > > +	match = acpi_match_device(dev->driver->acpi_match_table, dev);
> > > +	if (!match)
> > > +		return NULL;
> > > +
> > > +	return (void *)match->driver_data;
> > > +}
> > > +EXPORT_SYMBOL_GPL(acpi_device_get_match_data);
> 
> While I understand that the name follows the OF convention, I have some
> doubts on whether it is the best one.

Perhpas acpi_get_match_data() ?

-- 
~Vinod

  reply	other threads:[~2017-11-29 13:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10  2:32 [PATCH V3 1/4] Documentation: DT: qcom_hidma: bump HW revision for the bugfixed HW Sinan Kaya
2017-11-10  2:32 ` [PATCH V3 2/4] ACPI / bus: introduce acpi_device_get_match_data() function Sinan Kaya
2017-11-10  2:35   ` Sinan Kaya
2017-11-12  0:14     ` Rafael J. Wysocki
2017-11-29 13:55       ` Vinod Koul [this message]
2017-11-29 20:49         ` Sinan Kaya
2017-11-10  2:32 ` [PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision Sinan Kaya
2017-11-29 13:58   ` Vinod Koul
2017-11-29 22:14     ` Sinan Kaya
2017-11-10  2:32 ` [PATCH V3 4/4] dmaengine: qcom_hidma: add identity register support Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129135536.GD32417@localhost \
    --to=vinod.koul@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).