linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: cdall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] kvm: arm: don't treat unavailable HYP mode as an error
Date: Wed, 29 Nov 2017 18:12:59 +0100	[thread overview]
Message-ID: <20171129171259.GC10563@lvm> (raw)
In-Reply-To: <20171128151819.18669-1-ard.biesheuvel@linaro.org>

On Tue, Nov 28, 2017 at 03:18:19PM +0000, Ard Biesheuvel wrote:
> Since it is perfectly legal to run the kernel at EL1, it is not
> actually an error if HYP mode is not available when attempting to
> initialize KVM, given that KVM support cannot be built as a module.
> So demote the kvm_err() to kvm_info(), which prevents the error from
> appearing on an otherwise 'quiet' console.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  virt/kvm/arm/arm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 772bf74ac2e9..988c888a9667 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -1460,7 +1460,7 @@ int kvm_arch_init(void *opaque)
>  	bool in_hyp_mode;
>  
>  	if (!is_hyp_mode_available()) {
> -		kvm_err("HYP mode not available\n");
> +		kvm_info("HYP mode not available\n");
>  		return -ENODEV;
>  	}
>  
> -- 
> 2.11.0
> 
Applied, thanks.
-Christoffer

      parent reply	other threads:[~2017-11-29 17:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 15:18 [PATCH] kvm: arm: don't treat unavailable HYP mode as an error Ard Biesheuvel
2017-11-28 15:26 ` Marc Zyngier
2017-11-29 17:12 ` Christoffer Dall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129171259.GC10563@lvm \
    --to=cdall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).