* [PATCH] kvm: arm: don't treat unavailable HYP mode as an error
@ 2017-11-28 15:18 Ard Biesheuvel
2017-11-28 15:26 ` Marc Zyngier
2017-11-29 17:12 ` Christoffer Dall
0 siblings, 2 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2017-11-28 15:18 UTC (permalink / raw)
To: linux-arm-kernel
Since it is perfectly legal to run the kernel at EL1, it is not
actually an error if HYP mode is not available when attempting to
initialize KVM, given that KVM support cannot be built as a module.
So demote the kvm_err() to kvm_info(), which prevents the error from
appearing on an otherwise 'quiet' console.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
virt/kvm/arm/arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
index 772bf74ac2e9..988c888a9667 100644
--- a/virt/kvm/arm/arm.c
+++ b/virt/kvm/arm/arm.c
@@ -1460,7 +1460,7 @@ int kvm_arch_init(void *opaque)
bool in_hyp_mode;
if (!is_hyp_mode_available()) {
- kvm_err("HYP mode not available\n");
+ kvm_info("HYP mode not available\n");
return -ENODEV;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] kvm: arm: don't treat unavailable HYP mode as an error
2017-11-28 15:18 [PATCH] kvm: arm: don't treat unavailable HYP mode as an error Ard Biesheuvel
@ 2017-11-28 15:26 ` Marc Zyngier
2017-11-29 17:12 ` Christoffer Dall
1 sibling, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2017-11-28 15:26 UTC (permalink / raw)
To: linux-arm-kernel
On 28/11/17 15:18, Ard Biesheuvel wrote:
> Since it is perfectly legal to run the kernel at EL1, it is not
> actually an error if HYP mode is not available when attempting to
> initialize KVM, given that KVM support cannot be built as a module.
> So demote the kvm_err() to kvm_info(), which prevents the error from
> appearing on an otherwise 'quiet' console.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> virt/kvm/arm/arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 772bf74ac2e9..988c888a9667 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -1460,7 +1460,7 @@ int kvm_arch_init(void *opaque)
> bool in_hyp_mode;
>
> if (!is_hyp_mode_available()) {
> - kvm_err("HYP mode not available\n");
> + kvm_info("HYP mode not available\n");
> return -ENODEV;
> }
>
>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] kvm: arm: don't treat unavailable HYP mode as an error
2017-11-28 15:18 [PATCH] kvm: arm: don't treat unavailable HYP mode as an error Ard Biesheuvel
2017-11-28 15:26 ` Marc Zyngier
@ 2017-11-29 17:12 ` Christoffer Dall
1 sibling, 0 replies; 3+ messages in thread
From: Christoffer Dall @ 2017-11-29 17:12 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Nov 28, 2017 at 03:18:19PM +0000, Ard Biesheuvel wrote:
> Since it is perfectly legal to run the kernel at EL1, it is not
> actually an error if HYP mode is not available when attempting to
> initialize KVM, given that KVM support cannot be built as a module.
> So demote the kvm_err() to kvm_info(), which prevents the error from
> appearing on an otherwise 'quiet' console.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> virt/kvm/arm/arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c
> index 772bf74ac2e9..988c888a9667 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -1460,7 +1460,7 @@ int kvm_arch_init(void *opaque)
> bool in_hyp_mode;
>
> if (!is_hyp_mode_available()) {
> - kvm_err("HYP mode not available\n");
> + kvm_info("HYP mode not available\n");
> return -ENODEV;
> }
>
> --
> 2.11.0
>
Applied, thanks.
-Christoffer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-29 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-28 15:18 [PATCH] kvm: arm: don't treat unavailable HYP mode as an error Ard Biesheuvel
2017-11-28 15:26 ` Marc Zyngier
2017-11-29 17:12 ` Christoffer Dall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).