From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook
Date: Fri, 1 Dec 2017 10:39:20 +0100 [thread overview]
Message-ID: <20171201103920.1ed36f99@bbrezillon> (raw)
In-Reply-To: <20171130230246.61a9ed19@xps13>
On Thu, 30 Nov 2017 23:02:46 +0100
Miquel RAYNAL <miquel.raynal@free-electrons.com> wrote:
> > > diff --git a/drivers/mtd/nand/nand_base.c
> > > b/drivers/mtd/nand/nand_base.c index 630048f5abdc..4d1f2bda6095
> > > 100644 --- a/drivers/mtd/nand/nand_base.c
> > > +++ b/drivers/mtd/nand/nand_base.c
> > > @@ -3077,7 +3077,7 @@ int nand_erase_nand(struct mtd_info *mtd,
> > > struct erase_info *instr, status = chip->erase(mtd, page &
> > > chip->pagemask);
> > > /* See if block erase succeeded */
> > > - if (status & NAND_STATUS_FAIL) {
> > > + if (status) {
> > > pr_debug("%s: failed erase, page 0x%08x\n",
> > > __func__, page);
> > > instr->state = MTD_ERASE_FAILED;
> >
> > You forgot to patch single_erase() accordingly.
>
> Right, sorry about that, I will fix that.
If fixed it when applying, no need to resend.
Thanks,
Boris
>
> Thanks,
> Miqu?l
next prev parent reply other threads:[~2017-12-01 9:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 17:01 [PATCH 0/5] Introduce the new NAND core interface: ->exec_op() Miquel Raynal
2017-11-30 17:01 ` [PATCH 1/5] mtd: nand: use usual return values for the ->erase() hook Miquel Raynal
2017-11-30 20:51 ` Boris Brezillon
2017-11-30 22:02 ` Miquel RAYNAL
2017-12-01 2:12 ` Masahiro Yamada
2017-12-01 9:39 ` Boris Brezillon [this message]
2017-11-30 17:01 ` [PATCH 2/5] mtd: nand: provide several helpers to do common NAND operations Miquel Raynal
2017-12-01 2:38 ` Masahiro Yamada
2017-11-30 17:01 ` [PATCH 3/5] mtd: nand: force drivers to explicitly send READ/PROG commands Miquel Raynal
2017-12-01 2:39 ` Masahiro Yamada
2017-11-30 17:01 ` [PATCH 4/5] mtd: nand: use a static data_interface in the nand_chip structure Miquel Raynal
2017-12-01 9:38 ` Boris Brezillon
2017-11-30 17:01 ` [PATCH 5/5] mtd: nand: add ->exec_op() implementation Miquel Raynal
2017-11-30 20:50 ` Boris Brezillon
2017-11-30 22:25 ` Miquel RAYNAL
2017-12-01 9:50 ` Boris Brezillon
2017-12-01 9:57 ` Miquel RAYNAL
2017-12-01 11:07 ` Boris Brezillon
2017-12-01 9:37 ` [PATCH 0/5] Introduce the new NAND core interface: ->exec_op() Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201103920.1ed36f99@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).