linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/3] arm64: dts: meson-axg: add clock DT info for Meson AXG SoC
Date: Fri, 1 Dec 2017 08:34:37 -0800	[thread overview]
Message-ID: <20171201163437.GE19419@codeaurora.org> (raw)
In-Reply-To: <8353c264-3253-0268-91fc-8d42fbe82611@amlogic.com>

On 11/30, Yixun Lan wrote:
> Hi Stephen
> 
> On 11/30/17 03:35, Stephen Boyd wrote:
> > On 11/28, Yixun Lan wrote:
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> >> index b932a784b02a..36a2e98338a8 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> >> @@ -7,6 +7,7 @@
> >>  #include <dt-bindings/gpio/gpio.h>
> >>  #include <dt-bindings/interrupt-controller/irq.h>
> >>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >> +#include <dt-bindings/clock/axg-clkc.h>
> >>  
> >>  / {
> >>  	compatible = "amlogic,meson-axg";
> >> @@ -148,6 +149,20 @@
> >>  			#address-cells = <0>;
> >>  		};
> >>  
> >> +		hiubus: hiubus at ff63c000 {
> > 
> > Maybe just call the node "bus at ff63c000"?
> > 
> isn't this just a name? what's the benefits to change?
> personally, I tend to keep it this way, because it's better map to the
> data sheet
> 
> we also has 'aobus', 'cbus' scattered there..

Per the ePAPR node names are supposed to be generic, like disk,
cpu, display-controller, gpu, etc. I've never heard of a hiubus,
so probably it's some vendor specific thing? We have the phandle
anyway so it's not like we're losing much information here.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2017-12-01 16:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 12:53 [PATCH v3 0/3] add clk controller driver for Meson-AXG SoC Yixun Lan
2017-11-28 12:53 ` [PATCH v3 1/3] dt-bindings: clock: add compatible variant for the Meson-AXG Yixun Lan
2017-11-28 15:29   ` Rob Herring
2017-11-28 12:53 ` [PATCH v3 2/3] clk: meson-axg: add clock controller drivers Yixun Lan
2017-11-28 16:30   ` Rob Herring
2017-11-28 23:16     ` Yixun Lan
2017-11-29 19:34   ` Stephen Boyd
2017-11-30  6:01     ` Yixun Lan
2017-12-01 16:39       ` Stephen Boyd
2017-11-28 12:53 ` [PATCH v3 3/3] arm64: dts: meson-axg: add clock DT info for Meson AXG SoC Yixun Lan
2017-11-29 19:35   ` Stephen Boyd
2017-11-30  6:01     ` Yixun Lan
2017-12-01 16:34       ` Stephen Boyd [this message]
2017-12-01 16:59         ` Jerome Brunet
2017-12-06  1:00           ` Stephen Boyd
2017-12-06 19:11             ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201163437.GE19419@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).