From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: Add ethernet PHYs to the a bunch of Geminis
Date: Sun, 3 Dec 2017 17:06:58 +0100 [thread overview]
Message-ID: <20171203160658.GB7878@lunn.ch> (raw)
In-Reply-To: <20171203150457.21774-1-linus.walleij@linaro.org>
On Sun, Dec 03, 2017 at 04:04:57PM +0100, Linus Walleij wrote:
> These Gemini boards have Ethernet PHY on GPIO bit-banged
> MDIO, clearly defined in the corresponding OpenWRT
> ethernet patches since ages. Add them in accordance with
> the OpenWRT patch so we can use them when we add ethernet
> support.
>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
This is good as is, but i just wonder if the mdio node can be moved
into the .dtsi file. Four from six have the exact same setup. So i'm
guessing the reference design has been copied. So it is likely the
other two at the same. So you could move the mdio, set it to status
disable, and have these board enable it in their .dts file.
Andrew
next prev parent reply other threads:[~2017-12-03 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-03 15:04 [PATCH v2] ARM: dts: Add ethernet PHYs to the a bunch of Geminis Linus Walleij
2017-12-03 16:06 ` Andrew Lunn [this message]
2017-12-11 7:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203160658.GB7878@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).