linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging: vc04_services: Fix trivial style issues
Date: Mon, 4 Dec 2017 13:52:35 +0300	[thread overview]
Message-ID: <20171204105235.2nhmalxsd4uslesi@mwanda> (raw)
In-Reply-To: <30cc7b48def470f1bec8d8d255044f4f220531ee.1512368114.git.sky@genki.is>

On Mon, Dec 04, 2017 at 01:17:36AM -0500, Genki Sky wrote:
> In bcm2835-camera, handle the following checkpatch.pl types:
>   - EMBEDDED_FUNCTION_NAME
>   - MULTILINE_DEREFERENCE
>   - SPLIT_STRING
> 
> [ note: this is for Task 10 of http://eudyptula-challenge.org/ ]

Leave this part out or put it under the --- cut off.  We don't want it
in the final git log.

> 
> Signed-off-by: Genki Sky <sky@genki.is>

Split it up and resend.  Then it's a nice little cleanup.  It's cool
that checkpatch.pl started complaining about MULTILINE_DEREFERENCEs.

regards,
dan carpenter

  parent reply	other threads:[~2017-12-04 10:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04  6:17 [PATCH] staging: vc04_services: Fix trivial style issues Genki Sky
2017-12-04  7:31 ` Greg Kroah-Hartman
2017-12-04 10:52 ` Dan Carpenter [this message]
2017-12-05  2:39   ` [PATCH v2 0/3] " Genki Sky
2017-12-05  2:39     ` [PATCH v2 1/3] staging: vc04_services: Join multiline dereferences Genki Sky
2017-12-05  6:17       ` Greg Kroah-Hartman
2017-12-05  2:39     ` [PATCH v2 2/3] staging: vc04_services: Unsplit user-visible strings Genki Sky
2017-12-05  2:39     ` [PATCH v2 3/3] staging: vc04_services: Use __func__ Genki Sky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204105235.2nhmalxsd4uslesi@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).