From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] arm64: KVM: Move CPU ID reg trap setup off the world switch path
Date: Wed, 6 Dec 2017 11:53:00 +0100 [thread overview]
Message-ID: <20171206105300.GK32397@cbox> (raw)
In-Reply-To: <20171205123150.GX22781@e103592.cambridge.arm.com>
On Tue, Dec 05, 2017 at 12:31:51PM +0000, Dave Martin wrote:
> On Tue, Dec 05, 2017 at 10:09:15AM +0100, Christoffer Dall wrote:
> > On Fri, Dec 01, 2017 at 03:19:40PM +0000, Dave Martin wrote:
> > > The HCR_EL2.TID3 flag needs to be set when trapping guest access to
> > > the CPU ID registers is required. However, the decision about
> > > whether to set this bit does not need to be repeated at every
> > > switch to the guest.
> > >
> > > Instead, it's sufficient to make this decision once and record the
> > > outcome.
> > >
> > > This patch moves the decision to vcpu_reset_hcr() and records the
> > > choice made in vcpu->arch.hcr_el2. The world switch code can then
> > > load this directly when switching to the guest without the need for
> > > conditional logic on the critical path.
> > >
> > > Signed-off-by: Dave Martin <Dave.Martin@arm.com>
> > > Suggested-by: Christoffer Dall <christoffer.dall@linaro.org>
> > > Cc: Marc Zyngier <marc.zyngier@arm.com>
> >
> > Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
> >
> > >
> > > ---
> > >
> > > Note to maintainers: this was discussed on-list [1] prior to the merge
> > > window, but this patch implementing the agreed decision hasn't been
> > > posted previously.
> > >
> > > This should be considered a fix for v4.15.
> >
> > It's actually easier for me to apply this for v4.16 and base my VHE
> > optimization patches on it.
>
> If you're happy for this optimisation to be missing for v4.15, I'm fine
> with that.
>
> Can I leave it you to pick this up then?
Yes, I applied it to our queue already.
>
> I'll repost the other stuff from this series separately for Will to
> take care of.
>
Thanks,
-Christoffer
next prev parent reply other threads:[~2017-12-06 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 15:19 [PATCH 0/3] arm64: SVE fixes for v4.15-rc1 Dave Martin
2017-12-01 15:19 ` [PATCH 1/3] arm64: KVM: Move CPU ID reg trap setup off the world switch path Dave Martin
2017-12-05 9:09 ` Christoffer Dall
2017-12-05 12:31 ` Dave Martin
2017-12-06 10:53 ` Christoffer Dall [this message]
2017-12-06 11:55 ` Dave Martin
2017-12-01 15:19 ` [PATCH 2/3] arm64: fpsimd: Abstract out binding of task's fpsimd context to the cpu Dave Martin
2017-12-04 13:46 ` Ard Biesheuvel
2017-12-01 15:19 ` [PATCH 3/3] arm64/sve: KVM: Avoid dereference of dead task during guest entry Dave Martin
2017-12-04 13:53 ` Ard Biesheuvel
2017-12-04 15:36 ` Dave Martin
2017-12-05 9:43 ` Christoffer Dall
2017-12-05 12:40 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206105300.GK32397@cbox \
--to=christoffer.dall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).