From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap2: hide omap3_save_secure_ram on non-OMAP3 builds
Date: Wed, 6 Dec 2017 14:04:05 -0800 [thread overview]
Message-ID: <20171206220405.GZ28152@atomide.com> (raw)
In-Reply-To: <CAK8P3a13Or8OvttqiKo8Qg2q6UJwQPg0E5TGb02LUb+p8nB3kw@mail.gmail.com>
* Arnd Bergmann <arnd@arndb.de> [171206 21:51]:
> On Wed, Dec 6, 2017 at 5:29 PM, Dan Murphy <dmurphy@ti.com> wrote:
> > Arnd
> >
> > On 12/06/2017 09:57 AM, Tony Lindgren wrote:
> >> * Arnd Bergmann <arnd@arndb.de> [171206 14:18]:
> >>> In configurations without CONFIG_OMAP3 but with secure RAM support,
> >>> we now run into a link failure:
> >>>
> >>> arch/arm/mach-omap2/omap-secure.o: In function `omap3_save_secure_ram':
> >>> omap-secure.c:(.text+0x130): undefined reference to `save_secure_ram_context'
> >>>
> >>> The omap3_save_secure_ram() function is only called from the OMAP34xx
> >>> power management code, so we can simply hide that function in the
> >>> appropriate #ifdef.
> >>>
> >>> Fixes: d09220a887f7 ("ARM: OMAP2+: Fix SRAM virt to phys translation for save_secure_ram_context")
> >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >>
> >> Thanks for fixing it, want to apply directly to ARM SoC fixes
> >> where d09220a887f7 is now? If so:
> >>
> >> Acked-by: Tony Lindgren <tony@atomide.com>
> >
> > Found the same issue in our builds.
> > Compile tested the patch against different TI defconfig configurations.
> >
> > Tested-by: Dan Murphy <dmurphy@ti.com>
>
> Thanks!
>
> Unfortunately, I found another build problem with CONFIG_PM=n,
> sent an updated patch now, and will apply it to the fixes branch
> tomorrow keeping both of your Acked-by/Tested-by tags, unless
> I hear any objections or run into a third problem.
OK thanks works for me.
Tony
prev parent reply other threads:[~2017-12-06 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 14:15 [PATCH] ARM: omap2: hide omap3_save_secure_ram on non-OMAP3 builds Arnd Bergmann
2017-12-06 15:57 ` Tony Lindgren
2017-12-06 16:29 ` Dan Murphy
2017-12-06 21:49 ` Arnd Bergmann
2017-12-06 22:04 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206220405.GZ28152@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).