From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] spi: sun6i: disable/unprepare clocks on remove
Date: Thu, 7 Dec 2017 17:36:27 +0100 [thread overview]
Message-ID: <20171207163627.i4nrojgveczjfeox@flea.lan> (raw)
In-Reply-To: <20171207140453.55krsazvnfqr7ooe@agrajag.zerfleddert.de>
On Thu, Dec 07, 2017 at 03:04:53PM +0100, Tobias Jordan wrote:
> sun6i_spi_probe() uses sun6i_spi_runtime_resume() to prepare/enable
> clocks, so sun6i_spi_remove() should use sun6i_spi_runtime_suspend() to
> disable/unprepare them if we're not suspended.
> Replacing pm_runtime_disable() by pm_runtime_force_suspend() will ensure
> that sun6i_spi_runtime_suspend() is called if needed.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Fixes: 3558fe900e8af spi: sunxi: Add Allwinner A31 SPI controller driver
This isn't the proper fixes format.
> Signed-off-by: Tobias Jordan <Tobias.Jordan@elektrobit.com>
Once fixed,
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171207/1aaa8c26/attachment.sig>
next prev parent reply other threads:[~2017-12-07 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 14:04 [PATCH] spi: sun6i: disable/unprepare clocks on remove Tobias Jordan
2017-12-07 16:36 ` Maxime Ripard [this message]
2017-12-07 17:48 ` Applied "spi: sun6i: disable/unprepare clocks on remove" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207163627.i4nrojgveczjfeox@flea.lan \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox