From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: atmel-classd: select correct Kconfig symbol
Date: Fri, 8 Dec 2017 15:30:28 +0100 [thread overview]
Message-ID: <20171208143028.GZ21780@piout.net> (raw)
In-Reply-To: <20171205220759.GL21780@piout.net>
On 05/12/2017 at 23:07:59 +0100, Alexandre Belloni wrote:
> On 05/12/2017 at 14:28:28 +0100, Arnd Bergmann wrote:
> > On Tue, Dec 5, 2017 at 1:47 PM, Alexandre Belloni
> > <alexandre.belloni@free-electrons.com> wrote:
> > > On 05/12/2017 at 12:13:41 +0100, Arnd Bergmann wrote:
> > >
> > > Ok, does that solve both randconfigs?
> > >
> > > diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> > > index 4a56f3dfba51..dcee145dd179 100644
> > > --- a/sound/soc/atmel/Kconfig
> > > +++ b/sound/soc/atmel/Kconfig
> > > @@ -64,7 +64,7 @@ config SND_AT91_SOC_SAM9X5_WM8731
> > > config SND_ATMEL_SOC_CLASSD
> > > tristate "Atmel ASoC driver for boards using CLASSD"
> > > depends on ARCH_AT91 || COMPILE_TEST
> > > - select SND_ATMEL_SOC_DMA
> > > + select SND_SOC_GENERIC_DMAENGINE_PCM
> > > select REGMAP_MMIO
> > > help
> > > Say Y if you want to add support for Atmel ASoC driver for boards using
> >
> > Yes, that works as well and looks reliable. I've sent another
> > follow-up now, working on the
> > assumption that we actually need SND_ATMEL_SOC_DMA.
> >
> > Both patches make it build, but obviously only one of the two is
> > actually correct. I assume you know what you are doing, so if
> > you want to send your patch with a proper changelog, please add
> > my
> >
> > Tested-by: Arnd Bergmann <arnd@arndb.de>
> >
>
> Ok, I'll test on a real board before the end of the week (I need to find
> a speaker) and I'll send a proper patch.
>
So I've tested and this works properly, I've sent the patch (as you
probably have seen).
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-08 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 10:09 [PATCH] ASoC: atmel-classd: select correct Kconfig symbol Arnd Bergmann
2017-12-05 10:57 ` Alexandre Belloni
2017-12-05 11:13 ` Arnd Bergmann
2017-12-05 11:27 ` Nicolas Ferre
2017-12-05 12:47 ` Alexandre Belloni
2017-12-05 13:28 ` Arnd Bergmann
2017-12-05 22:07 ` Alexandre Belloni
2017-12-08 14:30 ` Alexandre Belloni [this message]
2017-12-05 12:48 ` Applied "ASoC: atmel-classd: select correct Kconfig symbol" to the asoc tree Mark Brown
2017-12-05 12:51 ` Mark Brown
2017-12-05 12:52 ` Nicolas Ferre
2017-12-05 12:48 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2017-12-08 14:18 [PATCH] ASoC: atmel-classd: select correct Kconfig symbol Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171208143028.GZ21780@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).