From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Mon, 11 Dec 2017 08:15:13 +0100 Subject: [PATCH 1/5] arm: dts: sun8i: a83t: Add I2C0 node In-Reply-To: <20171208215419.30396-2-mylene.josserand@free-electrons.com> References: <20171208215419.30396-1-mylene.josserand@free-electrons.com> <20171208215419.30396-2-mylene.josserand@free-electrons.com> Message-ID: <20171211071513.xgni3t6ihmeeebre@flea.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Fri, Dec 08, 2017 at 10:54:15PM +0100, Myl?ne Josserand wrote: > Add I2C0 node for A83T. > > Signed-off-by: Myl?ne Josserand > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 19acae1b4089..848cf3f19962 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -177,6 +177,17 @@ > #dma-cells = <1>; > }; > > + i2c0: i2c at 01c2ac00 { Drop the leading 0, it generates a warning in dtc. > + compatible = "allwinner,sun6i-a31-i2c"; Can you add a SoC-specific compatible there please? > + reg = <0x01c2ac00 0x400>; And you should order your nodes by physical address. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: