From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 04/14] ARM: dts: dra76x: Create a common file with MMC/SD IOdelay data
Date: Fri, 15 Dec 2017 08:32:07 -0800 [thread overview]
Message-ID: <20171215163207.GB3875@atomide.com> (raw)
In-Reply-To: <be4d8cfd-bdd3-aedf-9d9c-156de39d2621@ti.com>
* Kishon Vijay Abraham I <kishon@ti.com> [171215 06:12]:
> Hi Tony,
>
> On Thursday 14 December 2017 08:45 PM, Tony Lindgren wrote:
> > * Kishon Vijay Abraham I <kishon@ti.com> [171214 13:44]:
> >> +&dra7_pmx_core {
> >> + mmc1_pins_default: mmc1_pins_default {
> >> + pinctrl-single,pins = <
> >> + DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_clk.clk */
> >> + DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */
> >> + DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */
> >> + DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */
> >> + DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */
> >> + DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */
> >> + >;
> >> + };
> >> +
> >> + mmc1_pins_sdr12: mmc1_pins_sdr12 {
> >> + pinctrl-single,pins = <
> >> + DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_clk.clk */
> >> + DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */
> >> + DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */
> >> + DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */
> >> + DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */
> >> + DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */
> >> + >;
> >> + };
> >
> > Can't you just do:
> >
> > pinctrl-0 = <&mmc1_pins_default>;
> > pinctrl-1 = <&mmc1_pins_default>;
> > pinctrl-2 = <&mmc1_pins_hs>;
> > pinctrl-names = "default", "sdr12", "sdr25";
>
> just wanted to make sure every mode has it's own pinctrl group so that it's
> easy to review. Initially we were thinking something like
> mmc1_pins_default_sdr12_sdr25.
OK that naming works fine for me.
> But if you'd prefer we just use mmc1_pins_default for all modes that uses
> default pinmux configuration, I can change it that way too.
No up to you with the naming thanks.
Regards,
Tony
next prev parent reply other threads:[~2017-12-15 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-14 13:40 [PATCH 00/14] ARM: dra7/k2g: Use sdhci-omap for MMC/SD controller Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 01/14] ARM: multi_v7_defconfig: Enable CONFIG_MMC_SDHCI_OMAP Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 02/14] ARM: omap2plus_defconfig: " Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 03/14] ARM: configs: keystone: " Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 04/14] ARM: dts: dra76x: Create a common file with MMC/SD IOdelay data Kishon Vijay Abraham I
2017-12-14 15:15 ` Tony Lindgren
2017-12-15 6:09 ` Kishon Vijay Abraham I
2017-12-15 16:32 ` Tony Lindgren [this message]
2017-12-14 13:40 ` [PATCH 05/14] ARM: dts: dra76-evm: Shift to using common " Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 06/14] ARM: dts: dra76-evm: Add pinctrl data for higher speed MMC/SD modes Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 07/14] ARM: dts: am57xx-beagle-x15: Add "vqmmc-supply" property for mmc2 Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 08/14] ARM: dts: am57xx-idk: " Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 09/14] ARM: dts: dra76-evm: " Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 10/14] ARM: dts: dra71-evm: Correct evm_sd regulator max voltage Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 11/14] ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default mode Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 12/14] ARM: dts: am57xx-idk: " Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 13/14] ARM: dts: dra7: Use sdhci-omap programming model Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 14/14] ARM: dts: keystone-k2g: " Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215163207.GB3875@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).