From: w@1wt.eu (Willy Tarreau)
To: linux-arm-kernel@lists.infradead.org
Subject: pxa3xx_nand times out in 4.14 with JFFS2
Date: Sun, 17 Dec 2017 14:17:05 +0100 [thread overview]
Message-ID: <20171217131705.GA30726@1wt.eu> (raw)
In-Reply-To: <20171217133355.618e5f92@bbrezillon>
Hi Boris!
On Sun, Dec 17, 2017 at 01:33:55PM +0100, Boris Brezillon wrote:
> You should have a look at this thread [1], and in case you don't want
> to read everything,
I've read it entirely, it was very instructive!
> you can just test the solution proposed here [2].
>
> [1]http://linux-mtd.infradead.narkive.com/Rd5UaRPO/bug-pxa3xx-wait-time-out-when-scanning-for-bb
> [2]http://patchwork.ozlabs.org/patch/847411/
Well done for such a quick reply! I can confirm that your proposed
patch below does fix it for me! Now I understand why only jffs2 was
triggering the issue if it only affects OOB, and I guess I would have
faced it as well with nanddump had I thought about testing it.
I'm queuing this one here to continue to progress on my machine, feel
free to add my tested-by if the patch gets merged, or to ping me to
test any other option you'd like to confirm!
Thanks!
Willy
---
diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
index 321a90c..adb9fd8 100644
--- a/drivers/mtd/nand/pxa3xx_nand.c
+++ b/drivers/mtd/nand/pxa3xx_nand.c
@@ -950,6 +950,7 @@ static void prepare_start_command(struct pxa3xx_nand_info *info, int command)
switch (command) {
case NAND_CMD_READ0:
+ case NAND_CMD_READOOB:
case NAND_CMD_PAGEPROG:
info->use_ecc = 1;
break;
next prev parent reply other threads:[~2017-12-17 13:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 12:05 pxa3xx_nand times out in 4.14 with JFFS2 Willy Tarreau
2017-12-17 12:33 ` Boris Brezillon
2017-12-17 13:17 ` Willy Tarreau [this message]
2017-12-17 14:25 ` Ezequiel Garcia
2017-12-17 14:27 ` Ezequiel Garcia
2017-12-17 14:53 ` Boris Brezillon
2017-12-17 15:00 ` Willy Tarreau
2017-12-17 15:09 ` Willy Tarreau
2017-12-17 15:53 ` Ezequiel Garcia
2017-12-17 16:23 ` Willy Tarreau
2017-12-17 18:07 ` Boris Brezillon
2017-12-17 19:00 ` Willy Tarreau
2017-12-17 21:01 ` Ezequiel Garcia
2017-12-17 21:16 ` Willy Tarreau
2017-12-17 21:26 ` Boris Brezillon
2017-12-17 21:46 ` Miquel RAYNAL
2017-12-18 6:37 ` Willy Tarreau
2017-12-18 7:06 ` Willy Tarreau
2017-12-18 10:22 ` Miquel RAYNAL
2017-12-18 21:52 ` Willy Tarreau
2017-12-19 0:13 ` Miquel RAYNAL
2017-12-19 5:34 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171217131705.GA30726@1wt.eu \
--to=w@1wt.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).