From: andi.shyti@samsung.com (Andi Shyti)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree
Date: Mon, 18 Dec 2017 11:44:44 +0900 [thread overview]
Message-ID: <20171218024444.GA9140@gangnam.samsung> (raw)
In-Reply-To: <20171217224547.21481-2-embed3d@gmail.com>
Hi Philipp,
just a couple of small nitpicks.
> + u32 b_clk_freq;
[...]
> + /* Base clock frequency (optional) */
> + if (of_property_read_u32(dn, "clock-frequency", &b_clk_freq)) {
> + b_clk_freq = SUNXI_IR_BASE_CLK;
> + }
> +
how about you intialize 'b_clk_freq' to 'SUNXI_IR_BASE_CLK' and
just call 'of_property_read_u32' without if statement.
'b_clk_freq' value should not be changed if "clock-frequency"
is not present in the DTS.
This might avoid misinterpretation from static analyzers that
might think that 'b_clk_freq' is used uninitialized.
> + dev_info(dev, "set base clock frequency to %d Hz.\n", b_clk_freq);
Please use dev_dbg().
Andi
next prev parent reply other threads:[~2017-12-18 2:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 22:45 [PATCH 0/5] arm: sunxi: IR support for A83T Philipp Rossak
2017-12-17 22:45 ` [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree Philipp Rossak
2017-12-17 23:13 ` Sean Young
2017-12-18 2:44 ` Andi Shyti [this message]
2017-12-18 12:43 ` Philipp Rossak
2017-12-17 22:45 ` [PATCH 2/5] media: dt: bindings: Update binding documentation for sunxi IR controller Philipp Rossak
2017-12-18 7:46 ` Maxime Ripard
2017-12-17 22:45 ` [PATCH 3/5] arm: dts: sun8i: a83t: Add the ir pin for the A83T Philipp Rossak
2017-12-18 3:21 ` Chen-Yu Tsai
2017-12-17 22:45 ` [PATCH 4/5] arm: dts: sun8i: a83t: Add support for the ir interface Philipp Rossak
2017-12-18 7:47 ` Maxime Ripard
2017-12-17 22:45 ` [PATCH 5/5] arm: dts: sun8i: a83t: bananapi-m3: Enable IR controller Philipp Rossak
2017-12-18 3:30 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218024444.GA9140@gangnam.samsung \
--to=andi.shyti@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox