From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] ARM: tegra: enable cache via TF
Date: Tue, 19 Dec 2017 23:21:11 +0000 [thread overview]
Message-ID: <20171219232111.GH10595@n2100.armlinux.org.uk> (raw)
In-Reply-To: <6a164b2270a3e996c083e94bf5b1e27028c1135e.1500510157.git.mirq-linux@rere.qmqm.pl>
On Thu, Jul 20, 2017 at 02:29:25AM +0200, Micha? Miros?aw wrote:
> diff --git a/arch/arm/mach-tegra/reset-handler.S b/arch/arm/mach-tegra/reset-handler.S
> index 805f306fa6f7..aae7f5961563 100644
> --- a/arch/arm/mach-tegra/reset-handler.S
> +++ b/arch/arm/mach-tegra/reset-handler.S
> @@ -78,8 +78,20 @@ ENTRY(tegra_resume)
> orr r1, r1, #1
> str r1, [r0]
> #endif
> +#ifdef CONFIG_TRUSTED_FOUNDATIONS
> + adr r3, __tegra_smc_stack
> + stmia r3, {r4-r12, sp, lr}
>
> -#ifdef CONFIG_CACHE_L2X0
> + mov r0, #3 // local wake
> + mov r3, #0
> + mov r4, #0
> + dsb
> + .arch_extension sec
> + smc #0
> +
> + adr r3, __tegra_smc_stack
> + ldmia r3, {r4-r12, sp, pc}
You don't want to jump to the 'lr' value previously stacked here. I
also wonder whether you need all this stacking, or whether you're
just doing it because you don't know whether its necessary. From
what I can see, the only register that this code cares about is r8,
although it would be wise to place a comment in the code if the smc
call corrupts the other registers.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-12-19 23:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 0:29 [PATCH 0/9] Bringing Asus TF300T support to mainline Michał Mirosław
2017-07-20 0:29 ` [PATCH 1/9] ARM: enable secure platform-only erratas Michał Mirosław
2017-10-05 15:53 ` Dmitry Osipenko
2017-10-05 18:16 ` Dmitry Osipenko
2017-12-19 23:28 ` Russell King - ARM Linux
2017-12-20 12:49 ` Dmitry Osipenko
2017-07-20 0:29 ` [PATCH 2/9] arm: cache-l2x0: remove duplicate warning Michał Mirosław
2017-07-20 0:29 ` [PATCH 3/9] arm: cache-l2x0: share l2x0_base Michał Mirosław
2017-10-05 16:48 ` Mark Rutland
2017-12-19 23:10 ` Russell King - ARM Linux
2017-07-20 0:29 ` [PATCH 4/9] ARM: trusted_foundations: enable L2x0 cache via firmware_ops Michał Mirosław
2017-10-05 16:24 ` Dmitry Osipenko
2017-12-19 18:56 ` Dmitry Osipenko
2017-07-20 0:29 ` [PATCH 5/9] ARM: trusted_foundations: announce firmware version Michał Mirosław
2017-07-20 0:29 ` [PATCH 6/9] ARM: init: update secondary_data register documentation Michał Mirosław
2017-12-19 23:16 ` Russell King - ARM Linux
2017-07-20 0:29 ` [PATCH 8/9] ARM: tegra: avoid touching Secure registers in reset handler Michał Mirosław
2017-07-20 0:29 ` [PATCH 7/9] ARM: tegra: enable cache via TF Michał Mirosław
2017-12-19 19:07 ` Dmitry Osipenko
2017-12-19 23:21 ` Russell King - ARM Linux [this message]
2017-07-20 0:29 ` [PATCH 9/9] ARM: tegra: fix sleeping while atomic in CPU idle Michał Mirosław
2017-07-20 12:45 ` Jon Hunter
2017-07-20 16:28 ` Michał Mirosław
2017-07-21 8:15 ` Jon Hunter
2017-07-20 7:48 ` [PATCH 0/9] Bringing Asus TF300T support to mainline Mikko Perttunen
2017-07-20 15:07 ` Michał Mirosław
2017-10-04 21:25 ` Michał Mirosław
2017-10-05 15:52 ` Dmitry Osipenko
2017-10-05 16:07 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219232111.GH10595@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).