* [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation
[not found] <20171214165350.27850-1-malat@debian.org>
@ 2017-12-15 4:00 ` Viresh Kumar
2017-12-15 8:50 ` Jesper Nilsson
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Viresh Kumar @ 2017-12-15 4:00 UTC (permalink / raw)
To: linux-arm-kernel
On 14-12-17, 17:53, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> arch/arm/boot/dts/spear300.dtsi | 2 +-
> arch/arm/boot/dts/spear310.dtsi | 2 +-
> arch/arm/boot/dts/spear320.dtsi | 2 +-
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation
[not found] <20171214165350.27850-1-malat@debian.org>
2017-12-15 4:00 ` [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation Viresh Kumar
@ 2017-12-15 8:50 ` Jesper Nilsson
2017-12-15 8:59 ` Krzysztof Kozlowski
[not found] ` <20171215111620.20379-1-malat@debian.org>
3 siblings, 0 replies; 11+ messages in thread
From: Jesper Nilsson @ 2017-12-15 8:50 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 14, 2017 at 05:53:48PM +0100, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> arch/arm/boot/dts/artpec6.dtsi | 2 +-
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson at axis.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation
[not found] <20171214165350.27850-1-malat@debian.org>
2017-12-15 4:00 ` [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation Viresh Kumar
2017-12-15 8:50 ` Jesper Nilsson
@ 2017-12-15 8:59 ` Krzysztof Kozlowski
2017-12-15 11:19 ` Mathieu Malaterre
[not found] ` <20171215111620.20379-1-malat@debian.org>
3 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2017-12-15 8:59 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 14, 2017 at 5:53 PM, Mathieu Malaterre <malat@debian.org> wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> arch/arm/boot/dts/am3517.dtsi | 4 +--
> arch/arm/boot/dts/arm-realview-eb.dtsi | 18 +++++++-------
> arch/arm/boot/dts/arm-realview-pb1176.dts | 18 +++++++-------
> arch/arm/boot/dts/arm-realview-pb11mp.dts | 18 +++++++-------
> arch/arm/boot/dts/arm-realview-pbx.dtsi | 18 +++++++-------
> arch/arm/boot/dts/artpec6.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9261.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9261ek.dts | 2 +-
> arch/arm/boot/dts/at91sam9263.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9263ek.dts | 2 +-
> arch/arm/boot/dts/at91sam9g25ek.dts | 2 +-
> arch/arm/boot/dts/at91sam9g45.dtsi | 2 +-
> arch/arm/boot/dts/at91sam9m10g45ek.dts | 2 +-
> arch/arm/boot/dts/atlas7.dtsi | 12 ++++-----
> arch/arm/boot/dts/bcm11351.dtsi | 2 +-
> arch/arm/boot/dts/bcm21664.dtsi | 2 +-
> arch/arm/boot/dts/bcm283x.dtsi | 2 +-
> arch/arm/boot/dts/da850-lcdk.dts | 4 +--
> arch/arm/boot/dts/dm8148-evm.dts | 8 +++---
> arch/arm/boot/dts/dm8168-evm.dts | 8 +++---
> arch/arm/boot/dts/dra62x-j5eco-evm.dts | 8 +++---
> arch/arm/boot/dts/exynos5420.dtsi | 36 +++++++++++++--------------
> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +-
> arch/arm/boot/dts/imx7d.dtsi | 2 +-
> arch/arm/boot/dts/keystone-k2e-netcp.dtsi | 2 +-
> arch/arm/boot/dts/keystone-k2hk-netcp.dtsi | 2 +-
> arch/arm/boot/dts/keystone-k2l-netcp.dtsi | 2 +-
> arch/arm/boot/dts/omap3-cm-t3x.dtsi | 8 +++---
> arch/arm/boot/dts/omap3-evm-37xx.dts | 8 +++---
> arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 8 +++---
> arch/arm/boot/dts/s3c2416.dtsi | 2 +-
For Exynos and S3C:
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 25/25] arm: ste: dts: Remove leading 0x and 0s from bindings notation
[not found] ` <20171215111620.20379-1-malat@debian.org>
@ 2017-12-15 11:16 ` Mathieu Malaterre
[not found] ` <20171215111620.20379-5-malat@debian.org>
[not found] ` <20171215111620.20379-12-malat@debian.org>
2 siblings, 0 replies; 11+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 11:16 UTC (permalink / raw)
To: linux-arm-kernel
Improve the DTS files by removing all the leading "0x" and zeros to fix the
following dtc warnings:
Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
and
Warning (unit_address_format): Node /XXX unit name should not have leading 0s
Converted using the following command:
find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C
For simplicity, two sed expressions were used to solve each warnings separately.
To make the regex expression more robust a few other issues were resolved,
namely setting unit-address to lower case, and adding a whitespace before the
the opening curly brace:
https://elinux.org/Device_Tree_Linux#Linux_conventions
This will solve as a side effect warning:
Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
Reported-by: David Daney <ddaney@caviumnetworks.com>
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
arch/arm/boot/dts/ste-dbx5x0.dtsi | 2 +-
arch/arm/boot/dts/ste-nomadik-stn8815.dtsi | 130 ++++++++++++++---------------
arch/arm/boot/dts/ste-u300.dts | 50 +++++------
3 files changed, 91 insertions(+), 91 deletions(-)
diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi
index 2310a4e97768..cff985f9fb77 100644
--- a/arch/arm/boot/dts/ste-dbx5x0.dtsi
+++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi
@@ -474,7 +474,7 @@
clocks = <&prcc_pclk 5 0>;
};
- dma: dma-controller at 801C0000 {
+ dma: dma-controller at 801c0000 {
compatible = "stericsson,db8500-dma40", "stericsson,dma40";
reg = <0x801C0000 0x1000 0x40010000 0x800>;
reg-names = "base", "lcpa";
diff --git a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
index 68aab50a73ab..2970719ed22c 100644
--- a/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
+++ b/arch/arm/boot/dts/ste-nomadik-stn8815.dtsi
@@ -195,7 +195,7 @@
* MXTAL "Main Chrystal" is a chrystal oscillator @19.2 MHz
* that is parent of TIMCLK, PLL1 and PLL2
*/
- mxtal: mxtal at 19.2M {
+ mxtal: mxtal at 19.2m {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <19200000>;
@@ -207,7 +207,7 @@
* divided by 8. This clock is used by the timers and
* watchdog. See page 105 ff.
*/
- timclk: timclk at 2.4M {
+ timclk: timclk at 2.4m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <8>;
@@ -245,21 +245,21 @@
pll-id = <2>;
clocks = <&mxtal>;
};
- clk216: clk216 at 216M {
+ clk216: clk216 at 216m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <4>;
clock-mult = <1>;
clocks = <&pll2>;
};
- clk108: clk108 at 108M {
+ clk108: clk108 at 108m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <2>;
clock-mult = <1>;
clocks = <&clk216>;
};
- clk72: clk72 at 72M {
+ clk72: clk72 at 72m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
/* The data sheet does not say how this is derived */
@@ -267,7 +267,7 @@
clock-mult = <1>;
clocks = <&pll2>;
};
- clk48: clk48 at 48M {
+ clk48: clk48 at 48m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
/* The data sheet does not say how this is derived */
@@ -275,7 +275,7 @@
clock-mult = <1>;
clocks = <&pll2>;
};
- clk27: clk27 at 27M {
+ clk27: clk27 at 27m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <4>;
@@ -284,7 +284,7 @@
};
/* This apparently exists as well */
- ulpiclk: ulpiclk at 60M {
+ ulpiclk: ulpiclk at 60m {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <60000000>;
@@ -295,193 +295,193 @@
* peripheral clocking, clock gates.
*/
- hclkdma0: hclkdma0 at 48M {
+ hclkdma0: hclkdma0 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <0>;
clocks = <&hclk>;
};
- hclksmc: hclksmc at 48M {
+ hclksmc: hclksmc at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <1>;
clocks = <&hclk>;
};
- hclksdram: hclksdram at 48M {
+ hclksdram: hclksdram at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <2>;
clocks = <&hclk>;
};
- hclkdma1: hclkdma1 at 48M {
+ hclkdma1: hclkdma1 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <3>;
clocks = <&hclk>;
};
- hclkclcd: hclkclcd at 48M {
+ hclkclcd: hclkclcd at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <4>;
clocks = <&hclk>;
};
- pclkirda: pclkirda at 48M {
+ pclkirda: pclkirda at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <5>;
clocks = <&pclk>;
};
- pclkssp: pclkssp at 48M {
+ pclkssp: pclkssp at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <6>;
clocks = <&pclk>;
};
- pclkuart0: pclkuart0 at 48M {
+ pclkuart0: pclkuart0 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <7>;
clocks = <&pclk>;
};
- pclksdi: pclksdi at 48M {
+ pclksdi: pclksdi at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <8>;
clocks = <&pclk>;
};
- pclki2c0: pclki2c0 at 48M {
+ pclki2c0: pclki2c0 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <9>;
clocks = <&pclk>;
};
- pclki2c1: pclki2c1 at 48M {
+ pclki2c1: pclki2c1 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <10>;
clocks = <&pclk>;
};
- pclkuart1: pclkuart1 at 48M {
+ pclkuart1: pclkuart1 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <11>;
clocks = <&pclk>;
};
- pclkmsp0: pclkmsp0 at 48M {
+ pclkmsp0: pclkmsp0 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <12>;
clocks = <&pclk>;
};
- hclkusb: hclkusb at 48M {
+ hclkusb: hclkusb at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <13>;
clocks = <&hclk>;
};
- hclkdif: hclkdif at 48M {
+ hclkdif: hclkdif at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <14>;
clocks = <&hclk>;
};
- hclksaa: hclksaa at 48M {
+ hclksaa: hclksaa at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <15>;
clocks = <&hclk>;
};
- hclksva: hclksva at 48M {
+ hclksva: hclksva at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <16>;
clocks = <&hclk>;
};
- pclkhsi: pclkhsi at 48M {
+ pclkhsi: pclkhsi at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <17>;
clocks = <&pclk>;
};
- pclkxti: pclkxti at 48M {
+ pclkxti: pclkxti at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <18>;
clocks = <&pclk>;
};
- pclkuart2: pclkuart2 at 48M {
+ pclkuart2: pclkuart2 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <19>;
clocks = <&pclk>;
};
- pclkmsp1: pclkmsp1 at 48M {
+ pclkmsp1: pclkmsp1 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <20>;
clocks = <&pclk>;
};
- pclkmsp2: pclkmsp2 at 48M {
+ pclkmsp2: pclkmsp2 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <21>;
clocks = <&pclk>;
};
- pclkowm: pclkowm at 48M {
+ pclkowm: pclkowm at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <22>;
clocks = <&pclk>;
};
- hclkhpi: hclkhpi at 48M {
+ hclkhpi: hclkhpi at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <23>;
clocks = <&hclk>;
};
- pclkske: pclkske at 48M {
+ pclkske: pclkske at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <24>;
clocks = <&pclk>;
};
- pclkhsem: pclkhsem at 48M {
+ pclkhsem: pclkhsem at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <25>;
clocks = <&pclk>;
};
- hclk3d: hclk3d at 48M {
+ hclk3d: hclk3d at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <26>;
clocks = <&hclk>;
};
- hclkhash: hclkhash at 48M {
+ hclkhash: hclkhash at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <27>;
clocks = <&hclk>;
};
- hclkcryp: hclkcryp at 48M {
+ hclkcryp: hclkcryp at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <28>;
clocks = <&hclk>;
};
- pclkmshc: pclkmshc at 48M {
+ pclkmshc: pclkmshc at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <29>;
clocks = <&pclk>;
};
- hclkusbm: hclkusbm at 48M {
+ hclkusbm: hclkusbm at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <30>;
clocks = <&hclk>;
};
- hclkrng: hclkrng at 48M {
+ hclkrng: hclkrng at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <31>;
@@ -495,153 +495,153 @@
clock-id = <36>;
clocks = <&clk72 &clk48>;
};
- irdaclk: irdaclk at 48M {
+ irdaclk: irdaclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <37>;
clocks = <&clk48>;
};
- sspiclk: sspiclk at 48M {
+ sspiclk: sspiclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <38>;
clocks = <&clk48>;
};
- uart0clk: uart0clk at 48M {
+ uart0clk: uart0clk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <39>;
clocks = <&clk48>;
};
- sdiclk: sdiclk at 48M {
+ sdiclk: sdiclk at 48m {
/* Also called MCCLK in some documents */
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <40>;
clocks = <&clk48>;
};
- i2c0clk: i2c0clk at 48M {
+ i2c0clk: i2c0clk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <41>;
clocks = <&clk48>;
};
- i2c1clk: i2c1clk at 48M {
+ i2c1clk: i2c1clk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <42>;
clocks = <&clk48>;
};
- uart1clk: uart1clk at 48M {
+ uart1clk: uart1clk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <43>;
clocks = <&clk48>;
};
- mspclk0: mspclk0 at 48M {
+ mspclk0: mspclk0 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <44>;
clocks = <&clk48>;
};
- usbclk: usbclk at 48M {
+ usbclk: usbclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <45>;
clocks = <&clk48>; /* 48 MHz not ULPI */
};
- difclk: difclk at 72M {
+ difclk: difclk at 72m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <46>;
clocks = <&clk72>;
};
- ipi2cclk: ipi2cclk at 48M {
+ ipi2cclk: ipi2cclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <47>;
clocks = <&clk48>; /* Guess */
};
- ipbmcclk: ipbmcclk at 48M {
+ ipbmcclk: ipbmcclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <48>;
clocks = <&clk48>; /* Guess */
};
- hsiclkrx: hsiclkrx at 216M {
+ hsiclkrx: hsiclkrx at 216m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <49>;
clocks = <&clk216>;
};
- hsiclktx: hsiclktx at 108M {
+ hsiclktx: hsiclktx at 108m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <50>;
clocks = <&clk108>;
};
- uart2clk: uart2clk at 48M {
+ uart2clk: uart2clk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <51>;
clocks = <&clk48>;
};
- mspclk1: mspclk1 at 48M {
+ mspclk1: mspclk1 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <52>;
clocks = <&clk48>;
};
- mspclk2: mspclk2 at 48M {
+ mspclk2: mspclk2 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <53>;
clocks = <&clk48>;
};
- owmclk: owmclk at 48M {
+ owmclk: owmclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <54>;
clocks = <&clk48>; /* Guess */
};
- skeclk: skeclk at 48M {
+ skeclk: skeclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <56>;
clocks = <&clk48>; /* Guess */
};
- x3dclk: x3dclk at 48M {
+ x3dclk: x3dclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <58>;
clocks = <&clk48>; /* Guess */
};
- pclkmsp3: pclkmsp3 at 48M {
+ pclkmsp3: pclkmsp3 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <59>;
clocks = <&pclk>;
};
- mspclk3: mspclk3 at 48M {
+ mspclk3: mspclk3 at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <60>;
clocks = <&clk48>;
};
- mshcclk: mshcclk at 48M {
+ mshcclk: mshcclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <61>;
clocks = <&clk48>; /* Guess */
};
- usbmclk: usbmclk at 48M {
+ usbmclk: usbmclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <62>;
/* Stated as "48 MHz not ULPI clock" */
clocks = <&clk48>;
};
- rngcclk: rngcclk at 48M {
+ rngcclk: rngcclk at 48m {
#clock-cells = <0>;
compatible = "st,nomadik-src-clock";
clock-id = <63>;
diff --git a/arch/arm/boot/dts/ste-u300.dts b/arch/arm/boot/dts/ste-u300.dts
index 62ecb6a2fa39..08edee80f022 100644
--- a/arch/arm/boot/dts/ste-u300.dts
+++ b/arch/arm/boot/dts/ste-u300.dts
@@ -39,88 +39,88 @@
compatible = "fixed-clock";
clock-frequency = <32768>;
};
- pll13: pll13 at 13M {
+ pll13: pll13 at 13m {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <13000000>;
};
/* Slow bridge clocks under PLL13 */
- slow_clk: slow_clk at 13M {
+ slow_clk: slow_clk at 13m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <0>; /* Slow */
clock-id = <0>;
clocks = <&pll13>;
};
- uart0_clk: uart0_clk at 13M {
+ uart0_clk: uart0_clk at 13m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <0>; /* Slow */
clock-id = <1>;
clocks = <&slow_clk>;
};
- gpio_clk: gpio_clk at 13M {
+ gpio_clk: gpio_clk at 13m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <0>; /* Slow */
clock-id = <4>;
clocks = <&slow_clk>;
};
- rtc_clk: rtc_clk at 13M {
+ rtc_clk: rtc_clk at 13m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <0>; /* Slow */
clock-id = <6>;
clocks = <&slow_clk>;
};
- apptimer_clk: app_tmr_clk at 13M {
+ apptimer_clk: app_tmr_clk at 13m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <0>; /* Slow */
clock-id = <7>;
clocks = <&slow_clk>;
};
- acc_tmr_clk at 13M {
+ acc_tmr_clk at 13m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <0>; /* Slow */
clock-id = <8>;
clocks = <&slow_clk>;
};
- pll208: pll208 at 208M {
+ pll208: pll208 at 208m {
#clock-cells = <0>;
compatible = "fixed-clock";
clock-frequency = <208000000>;
};
- app208: app_208_clk at 208M {
+ app208: app_208_clk at 208m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <1>;
clock-mult = <1>;
clocks = <&pll208>;
};
- cpu_clk at 208M {
+ cpu_clk at 208m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <3>;
clocks = <&app208>;
};
- app104: app_104_clk at 104M {
+ app104: app_104_clk at 104m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <2>;
clock-mult = <1>;
clocks = <&pll208>;
};
- semi_clk at 104M {
+ semi_clk at 104m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <9>;
clocks = <&app104>;
};
- app52: app_52_clk at 52M {
+ app52: app_52_clk at 52m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <4>;
@@ -128,49 +128,49 @@
clocks = <&pll208>;
};
/* AHB subsystem clocks */
- ahb_clk: ahb_subsys_clk at 52M {
+ ahb_clk: ahb_subsys_clk at 52m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <10>;
clocks = <&app52>;
};
- intcon_clk at 52M {
+ intcon_clk at 52m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <12>;
clocks = <&ahb_clk>;
};
- emif_clk at 52M {
+ emif_clk at 52m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <5>;
clocks = <&ahb_clk>;
};
- dmac_clk: dmac_clk at 52M {
+ dmac_clk: dmac_clk at 52m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <4>;
clocks = <&app52>;
};
- fsmc_clk: fsmc_clk at 52M {
+ fsmc_clk: fsmc_clk at 52m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <6>;
clocks = <&app52>;
};
- xgam_clk: xgam_clk at 52M {
+ xgam_clk: xgam_clk at 52m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <2>; /* Rest */
clock-id = <8>;
clocks = <&app52>;
};
- app26: app_26_clk at 26M {
+ app26: app_26_clk at 26m {
#clock-cells = <0>;
compatible = "fixed-factor-clock";
clock-div = <2>;
@@ -178,28 +178,28 @@
clocks = <&app52>;
};
/* Fast bridge clocks */
- fast_clk: fast_clk at 26M {
+ fast_clk: fast_clk at 26m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <1>; /* Fast */
clock-id = <0>;
clocks = <&app26>;
};
- i2c0_clk: i2c0_clk at 26M {
+ i2c0_clk: i2c0_clk at 26m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <1>; /* Fast */
clock-id = <1>;
clocks = <&fast_clk>;
};
- i2c1_clk: i2c1_clk at 26M {
+ i2c1_clk: i2c1_clk at 26m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <1>; /* Fast */
clock-id = <2>;
clocks = <&fast_clk>;
};
- mmc_pclk: mmc_p_clk at 26M {
+ mmc_pclk: mmc_p_clk at 26m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <1>; /* Fast */
@@ -211,7 +211,7 @@
compatible = "stericsson,u300-syscon-mclk";
clocks = <&mmc_pclk>;
};
- spi_clk: spi_p_clk at 26M {
+ spi_clk: spi_p_clk at 26m {
#clock-cells = <0>;
compatible = "stericsson,u300-syscon-clk";
clock-type = <1>; /* Fast */
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation
2017-12-15 8:59 ` Krzysztof Kozlowski
@ 2017-12-15 11:19 ` Mathieu Malaterre
2017-12-15 12:18 ` Mathieu Malaterre
0 siblings, 1 reply; 11+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 11:19 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 15, 2017 at 9:59 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Dec 14, 2017 at 5:53 PM, Mathieu Malaterre <malat@debian.org> wrote:
>> Improve the DTS files by removing all the leading "0x" and zeros to fix the
>> following dtc warnings:
>>
>> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>>
>> and
>>
>> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>>
>> Converted using the following command:
>>
>> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>>
>> For simplicity, two sed expressions were used to solve each warnings separately.
>>
>> To make the regex expression more robust a few other issues were resolved,
>> namely setting unit-address to lower case, and adding a whitespace before the
>> the opening curly brace:
>>
>> https://elinux.org/Device_Tree_Linux#Linux_conventions
>>
>> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>>
>> Reported-by: David Daney <ddaney@caviumnetworks.com>
>> Suggested-by: Rob Herring <robh@kernel.org>
>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>> ---
>> arch/arm/boot/dts/am3517.dtsi | 4 +--
>> arch/arm/boot/dts/arm-realview-eb.dtsi | 18 +++++++-------
>> arch/arm/boot/dts/arm-realview-pb1176.dts | 18 +++++++-------
>> arch/arm/boot/dts/arm-realview-pb11mp.dts | 18 +++++++-------
>> arch/arm/boot/dts/arm-realview-pbx.dtsi | 18 +++++++-------
>> arch/arm/boot/dts/artpec6.dtsi | 2 +-
>> arch/arm/boot/dts/at91sam9261.dtsi | 2 +-
>> arch/arm/boot/dts/at91sam9261ek.dts | 2 +-
>> arch/arm/boot/dts/at91sam9263.dtsi | 2 +-
>> arch/arm/boot/dts/at91sam9263ek.dts | 2 +-
>> arch/arm/boot/dts/at91sam9g25ek.dts | 2 +-
>> arch/arm/boot/dts/at91sam9g45.dtsi | 2 +-
>> arch/arm/boot/dts/at91sam9m10g45ek.dts | 2 +-
>> arch/arm/boot/dts/atlas7.dtsi | 12 ++++-----
>> arch/arm/boot/dts/bcm11351.dtsi | 2 +-
>> arch/arm/boot/dts/bcm21664.dtsi | 2 +-
>> arch/arm/boot/dts/bcm283x.dtsi | 2 +-
>> arch/arm/boot/dts/da850-lcdk.dts | 4 +--
>> arch/arm/boot/dts/dm8148-evm.dts | 8 +++---
>> arch/arm/boot/dts/dm8168-evm.dts | 8 +++---
>> arch/arm/boot/dts/dra62x-j5eco-evm.dts | 8 +++---
>> arch/arm/boot/dts/exynos5420.dtsi | 36 +++++++++++++--------------
>> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +-
>> arch/arm/boot/dts/imx7d.dtsi | 2 +-
>> arch/arm/boot/dts/keystone-k2e-netcp.dtsi | 2 +-
>> arch/arm/boot/dts/keystone-k2hk-netcp.dtsi | 2 +-
>> arch/arm/boot/dts/keystone-k2l-netcp.dtsi | 2 +-
>> arch/arm/boot/dts/omap3-cm-t3x.dtsi | 8 +++---
>> arch/arm/boot/dts/omap3-evm-37xx.dts | 8 +++---
>> arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 8 +++---
>> arch/arm/boot/dts/s3c2416.dtsi | 2 +-
>
> For Exynos and S3C:
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
As discussed with Krzysztof, I've split the ARM patch into subarch.
Please drop this one.
Thanks
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation
2017-12-15 11:19 ` Mathieu Malaterre
@ 2017-12-15 12:18 ` Mathieu Malaterre
2017-12-15 12:41 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 12:18 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 15, 2017 at 12:19 PM, Mathieu Malaterre <malat@debian.org> wrote:
> On Fri, Dec 15, 2017 at 9:59 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Thu, Dec 14, 2017 at 5:53 PM, Mathieu Malaterre <malat@debian.org> wrote:
>>> Improve the DTS files by removing all the leading "0x" and zeros to fix the
>>> following dtc warnings:
>>>
>>> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>>>
>>> and
>>>
>>> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>>>
>>> Converted using the following command:
>>>
>>> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
>>>
>>> For simplicity, two sed expressions were used to solve each warnings separately.
>>>
>>> To make the regex expression more robust a few other issues were resolved,
>>> namely setting unit-address to lower case, and adding a whitespace before the
>>> the opening curly brace:
>>>
>>> https://elinux.org/Device_Tree_Linux#Linux_conventions
>>>
>>> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>>>
>>> Reported-by: David Daney <ddaney@caviumnetworks.com>
>>> Suggested-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Mathieu Malaterre <malat@debian.org>
>>> ---
>>> arch/arm/boot/dts/am3517.dtsi | 4 +--
>>> arch/arm/boot/dts/arm-realview-eb.dtsi | 18 +++++++-------
>>> arch/arm/boot/dts/arm-realview-pb1176.dts | 18 +++++++-------
>>> arch/arm/boot/dts/arm-realview-pb11mp.dts | 18 +++++++-------
>>> arch/arm/boot/dts/arm-realview-pbx.dtsi | 18 +++++++-------
>>> arch/arm/boot/dts/artpec6.dtsi | 2 +-
>>> arch/arm/boot/dts/at91sam9261.dtsi | 2 +-
>>> arch/arm/boot/dts/at91sam9261ek.dts | 2 +-
>>> arch/arm/boot/dts/at91sam9263.dtsi | 2 +-
>>> arch/arm/boot/dts/at91sam9263ek.dts | 2 +-
>>> arch/arm/boot/dts/at91sam9g25ek.dts | 2 +-
>>> arch/arm/boot/dts/at91sam9g45.dtsi | 2 +-
>>> arch/arm/boot/dts/at91sam9m10g45ek.dts | 2 +-
>>> arch/arm/boot/dts/atlas7.dtsi | 12 ++++-----
>>> arch/arm/boot/dts/bcm11351.dtsi | 2 +-
>>> arch/arm/boot/dts/bcm21664.dtsi | 2 +-
>>> arch/arm/boot/dts/bcm283x.dtsi | 2 +-
>>> arch/arm/boot/dts/da850-lcdk.dts | 4 +--
>>> arch/arm/boot/dts/dm8148-evm.dts | 8 +++---
>>> arch/arm/boot/dts/dm8168-evm.dts | 8 +++---
>>> arch/arm/boot/dts/dra62x-j5eco-evm.dts | 8 +++---
>>> arch/arm/boot/dts/exynos5420.dtsi | 36 +++++++++++++--------------
>>> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +-
>>> arch/arm/boot/dts/imx7d.dtsi | 2 +-
>>> arch/arm/boot/dts/keystone-k2e-netcp.dtsi | 2 +-
>>> arch/arm/boot/dts/keystone-k2hk-netcp.dtsi | 2 +-
>>> arch/arm/boot/dts/keystone-k2l-netcp.dtsi | 2 +-
>>> arch/arm/boot/dts/omap3-cm-t3x.dtsi | 8 +++---
>>> arch/arm/boot/dts/omap3-evm-37xx.dts | 8 +++---
>>> arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 8 +++---
>>> arch/arm/boot/dts/s3c2416.dtsi | 2 +-
>>
>> For Exynos and S3C:
>> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> As discussed with Krzysztof, I've split the ARM patch into subarch.
> Please drop this one.
Hum...looks like my internet provider just blacklisted me for too many
recipient in the mail. I'll do my best to resolve this, and send the
rest of the series.
-M
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation
2017-12-15 12:18 ` Mathieu Malaterre
@ 2017-12-15 12:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2017-12-15 12:41 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 15, 2017 at 1:18 PM, Mathieu Malaterre <malat@debian.org> wrote:
>> As discussed with Krzysztof, I've split the ARM patch into subarch.
>> Please drop this one.
>
> Hum...looks like my internet provider just blacklisted me for too many
> recipient in the mail. I'll do my best to resolve this, and send the
> rest of the series.
You can fix this by:
1. sending each mail separately (some for-do loop in bash with 'git
send-email --cc-cmd "scripts/get_maintainer.pl --no-git --no-roles
--no-rolestats --no-git-fallback"') because these are really
independent patches,
2. create a cover letter sent to everyone but send particular commits
only to respective folks:
a. get list of cc for cover letter:
scripts/get_maintainer.pl --no-multiline --interactive --separator=\''
--to '\' --no-git --no-roles --no-rolestats --no-git-fallback 00*
b. send patches (except cover letter now):
git send-email --cc-cmd "scripts/get_maintainer.pl --no-git --no-roles
--no-rolestats --no-git-fallback" --to linux-kernel at vger.kernel.org
--no-thread --in-reply-to='<COVER_LETER_THREAD_ID>' 000[1-9]-*
00[1-9]*-*
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 05/25] arm: imx: dts: Remove leading 0x and 0s from bindings notation
@ 2017-12-15 12:46 Mathieu Malaterre
2017-12-15 12:51 ` Fabio Estevam
0 siblings, 1 reply; 11+ messages in thread
From: Mathieu Malaterre @ 2017-12-15 12:46 UTC (permalink / raw)
To: linux-arm-kernel
Improve the DTS files by removing all the leading "0x" and zeros to fix the
following dtc warnings:
Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
and
Warning (unit_address_format): Node /XXX unit name should not have leading 0s
Converted using the following command:
find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C
For simplicity, two sed expressions were used to solve each warnings separately.
To make the regex expression more robust a few other issues were resolved,
namely setting unit-address to lower case, and adding a whitespace before the
the opening curly brace:
https://elinux.org/Device_Tree_Linux#Linux_conventions
This will solve as a side effect warning:
Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
Reported-by: David Daney <ddaney@caviumnetworks.com>
Suggested-by: Rob Herring <robh@kernel.org>
Signed-off-by: Mathieu Malaterre <malat@debian.org>
---
arch/arm/boot/dts/imx6q-display5.dtsi | 2 +-
arch/arm/boot/dts/imx7d.dtsi | 2 +-
arch/arm/boot/dts/imx7s.dtsi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-display5.dtsi b/arch/arm/boot/dts/imx6q-display5.dtsi
index 4084de43d4d9..09085fde3341 100644
--- a/arch/arm/boot/dts/imx6q-display5.dtsi
+++ b/arch/arm/boot/dts/imx6q-display5.dtsi
@@ -255,7 +255,7 @@
pinctrl-0 = <&pinctrl_i2c1>;
status = "okay";
- codec: tfa9879 at 6C {
+ codec: tfa9879 at 6c {
#sound-dai-cells = <0>;
compatible = "nxp,tfa9879";
reg = <0x6C>;
diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 4d308d17f040..369d5a166b3e 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -129,7 +129,7 @@
status = "disabled";
};
- pcie: pcie at 0x33800000 {
+ pcie: pcie at 33800000 {
compatible = "fsl,imx7d-pcie", "snps,dw-pcie";
reg = <0x33800000 0x4000>,
<0x4ff00000 0x80000>;
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 82ad26e766eb..a00ba897e58d 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -583,7 +583,7 @@
#address-cells = <1>;
#size-cells = <0>;
- pgc_pcie_phy: pgc-power-domain at IMX7_POWER_DOMAIN_PCIE_PHY {
+ pgc_pcie_phy: pgc-power-domain at imx7_power_domain_pcie_phy {
#power-domain-cells = <0>;
reg = <IMX7_POWER_DOMAIN_PCIE_PHY>;
power-supply = <®_1p0d>;
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 05/25] arm: imx: dts: Remove leading 0x and 0s from bindings notation
2017-12-15 12:46 [PATCH 05/25] arm: imx: " Mathieu Malaterre
@ 2017-12-15 12:51 ` Fabio Estevam
0 siblings, 0 replies; 11+ messages in thread
From: Fabio Estevam @ 2017-12-15 12:51 UTC (permalink / raw)
To: linux-arm-kernel
Hi Mathieu,
On Fri, Dec 15, 2017 at 10:46 AM, Mathieu Malaterre <malat@debian.org> wrote:
reg = <0x6C>;
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 4d308d17f040..369d5a166b3e 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -129,7 +129,7 @@
> status = "disabled";
> };
>
> - pcie: pcie at 0x33800000 {
> + pcie: pcie at 33800000 {
I have already sent a fix for this one.
> compatible = "fsl,imx7d-pcie", "snps,dw-pcie";
> reg = <0x33800000 0x4000>,
> <0x4ff00000 0x80000>;
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 82ad26e766eb..a00ba897e58d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -583,7 +583,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pgc_pcie_phy: pgc-power-domain at IMX7_POWER_DOMAIN_PCIE_PHY {
> + pgc_pcie_phy: pgc-power-domain at imx7_power_domain_pcie_phy {
Original code was correct.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 05/25] arm: imx: dts: Remove leading 0x and 0s from bindings notation
[not found] ` <20171215111620.20379-5-malat@debian.org>
@ 2017-12-26 4:17 ` Shawn Guo
0 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2017-12-26 4:17 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Dec 15, 2017 at 12:15:55PM +0100, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This will solve as a side effect warning:
>
> Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> arch/arm/boot/dts/imx6q-display5.dtsi | 2 +-
> arch/arm/boot/dts/imx7d.dtsi | 2 +-
> arch/arm/boot/dts/imx7s.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6q-display5.dtsi b/arch/arm/boot/dts/imx6q-display5.dtsi
> index 4084de43d4d9..09085fde3341 100644
> --- a/arch/arm/boot/dts/imx6q-display5.dtsi
> +++ b/arch/arm/boot/dts/imx6q-display5.dtsi
> @@ -255,7 +255,7 @@
> pinctrl-0 = <&pinctrl_i2c1>;
> status = "okay";
>
> - codec: tfa9879 at 6C {
> + codec: tfa9879 at 6c {
> #sound-dai-cells = <0>;
> compatible = "nxp,tfa9879";
> reg = <0x6C>;
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 4d308d17f040..369d5a166b3e 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -129,7 +129,7 @@
> status = "disabled";
> };
>
> - pcie: pcie at 0x33800000 {
> + pcie: pcie at 33800000 {
> compatible = "fsl,imx7d-pcie", "snps,dw-pcie";
> reg = <0x33800000 0x4000>,
> <0x4ff00000 0x80000>;
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 82ad26e766eb..a00ba897e58d 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -583,7 +583,7 @@
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pgc_pcie_phy: pgc-power-domain at IMX7_POWER_DOMAIN_PCIE_PHY {
> + pgc_pcie_phy: pgc-power-domain at imx7_power_domain_pcie_phy {
I think this is broken, as IMX7_POWER_DOMAIN_PCIE_PHY is a define here.
Shawn
> #power-domain-cells = <0>;
> reg = <IMX7_POWER_DOMAIN_PCIE_PHY>;
> power-supply = <®_1p0d>;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 12/25] arm: socfpga: dts: Remove leading 0x and 0s from bindings notation
[not found] ` <20171215111620.20379-12-malat@debian.org>
@ 2018-01-11 14:38 ` Dinh Nguyen
0 siblings, 0 replies; 11+ messages in thread
From: Dinh Nguyen @ 2018-01-11 14:38 UTC (permalink / raw)
To: linux-arm-kernel
On 12/15/2017 05:16 AM, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
>
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
>
> and
>
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
>
> Converted using the following command:
>
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C
>
> For simplicity, two sed expressions were used to solve each warnings separately.
>
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
>
> https://elinux.org/Device_Tree_Linux#Linux_conventions
>
> This will solve as a side effect warning:
>
> Warning (simple_bus_reg): Node /XXX@<UPPER> simple-bus unit address format error, expected "<lower>"
>
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
>
> Reported-by: David Daney <ddaney@caviumnetworks.com>
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
> arch/arm/boot/dts/socfpga.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Dinh
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2018-01-11 14:38 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20171214165350.27850-1-malat@debian.org>
2017-12-15 4:00 ` [PATCH] arm: dts: Remove leading 0x and 0s from bindings notation Viresh Kumar
2017-12-15 8:50 ` Jesper Nilsson
2017-12-15 8:59 ` Krzysztof Kozlowski
2017-12-15 11:19 ` Mathieu Malaterre
2017-12-15 12:18 ` Mathieu Malaterre
2017-12-15 12:41 ` Krzysztof Kozlowski
[not found] ` <20171215111620.20379-1-malat@debian.org>
2017-12-15 11:16 ` [PATCH 25/25] arm: ste: " Mathieu Malaterre
[not found] ` <20171215111620.20379-5-malat@debian.org>
2017-12-26 4:17 ` [PATCH 05/25] arm: imx: " Shawn Guo
[not found] ` <20171215111620.20379-12-malat@debian.org>
2018-01-11 14:38 ` [PATCH 12/25] arm: socfpga: " Dinh Nguyen
2017-12-15 12:46 [PATCH 05/25] arm: imx: " Mathieu Malaterre
2017-12-15 12:51 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).