linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support
@ 2017-12-14 17:14 Fabio Estevam
  2017-12-14 17:14 ` [PATCH 2/2] ARM: dts: imx6sx: Fix PCI non-prefetchable memory range Fabio Estevam
  2017-12-15  2:27 ` [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support Fabio Estevam
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2017-12-14 17:14 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

When I added PCI support for this board I was testing with mainline U-Boot,
which has PCI support and enables the i.mx6sx PCI power domain.

When running on a U-Boot without PCI support, such as the one provided
by NXP a kernel hang is observed.

Better to disable the pci node for now, until the i.MX6SX PCI power domain
is properly implemented in the kernel.

Reported-by: Abel Vesa <abel.vesa@nxp.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx6sx-sdb.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi
index d57a41c..bb0fe35 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dtsi
+++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi
@@ -215,7 +215,8 @@
 	pinctrl-0 = <&pinctrl_pcie>;
 	reset-gpio = <&gpio2 0 GPIO_ACTIVE_LOW>;
 	vpcie-supply = <&reg_pcie_gpio>;
-	status = "okay";
+	/* Keep it disable until mx6sx pci domain is supported */
+	status = "disabled";
 };
 
 &lcdif1 {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: imx6sx: Fix PCI non-prefetchable memory range
  2017-12-14 17:14 [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support Fabio Estevam
@ 2017-12-14 17:14 ` Fabio Estevam
  2017-12-26  7:36   ` Shawn Guo
  2017-12-15  2:27 ` [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support Fabio Estevam
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2017-12-14 17:14 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

The third cell of the PCI non-prefetchable memory range should be
0x08000000, so change it accordingly.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx6sx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 40c6738c..f41e389 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -1313,7 +1313,7 @@
 			device_type = "pci";
 			bus-range = <0x00 0xff>;
 			ranges = <0x81000000 0 0          0x08f80000 0 0x00010000 /* downstream I/O */
-				  0x82000000 0 0x01000000 0x08000000 0 0x00f00000>; /* non-prefetchable memory */
+				  0x82000000 0 0x08000000 0x08000000 0 0x00f00000>; /* non-prefetchable memory */
 			num-lanes = <1>;
 			interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "msi";
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support
  2017-12-14 17:14 [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support Fabio Estevam
  2017-12-14 17:14 ` [PATCH 2/2] ARM: dts: imx6sx: Fix PCI non-prefetchable memory range Fabio Estevam
@ 2017-12-15  2:27 ` Fabio Estevam
  1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2017-12-15  2:27 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Shawn,

On Thu, Dec 14, 2017 at 3:14 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> When I added PCI support for this board I was testing with mainline U-Boot,
> which has PCI support and enables the i.mx6sx PCI power domain.
>
> When running on a U-Boot without PCI support, such as the one provided
> by NXP a kernel hang is observed.
>
> Better to disable the pci node for now, until the i.MX6SX PCI power domain
> is properly implemented in the kernel.

Just sent two patches that add i.MX6SX PCI power domain support.

If they are accepted then this one can be discarded.

Patch 2/2 of this series should still be applied though.

Thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: imx6sx: Fix PCI non-prefetchable memory range
  2017-12-14 17:14 ` [PATCH 2/2] ARM: dts: imx6sx: Fix PCI non-prefetchable memory range Fabio Estevam
@ 2017-12-26  7:36   ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2017-12-26  7:36 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 14, 2017 at 03:14:27PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> The third cell of the PCI non-prefetchable memory range should be
> 0x08000000, so change it accordingly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied this one, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-12-26  7:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-14 17:14 [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support Fabio Estevam
2017-12-14 17:14 ` [PATCH 2/2] ARM: dts: imx6sx: Fix PCI non-prefetchable memory range Fabio Estevam
2017-12-26  7:36   ` Shawn Guo
2017-12-15  2:27 ` [PATCH 1/2] ARM: dts: imx6sx-sdb: Disable PCI support Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).