From: mingo@kernel.org (Ingo Molnar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/8] module: use relative references for __ksymtab entries
Date: Thu, 28 Dec 2017 13:05:31 +0100 [thread overview]
Message-ID: <20171228120531.xhcb4dg2qu2z5ssp@gmail.com> (raw)
In-Reply-To: <CAKv+Gu-wRtfnGfrEjuxR5YkCpZM-nQHZShROEdbcEh=fSiWf5A@mail.gmail.com>
* Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> Annoyingly, we need this because there is a single instance of a
> special section that ends up in the EFI stub code: we build lib/sort.c
> again as a EFI libstub object, and given that sort() is exported, we
> end up with a ksymtab section in the EFI stub. The sort() thing has
> caused issues before [0], so perhaps I should just clone sort.c into
> drivers/firmware/efi/libstub and get rid of that hack.
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=29f9007b3182ab3f328a31da13e6b1c9072f7a95
If the root problem is early bootstrap code randomly using generic facility that
isn't __init, then we should definitely improve tooling to at least detect these
problems.
As bootstrap code gets improved (KASLR, more complex decompression, etc. etc.) we
keep using new bits of generic facilities...
So this should definitely not be hidden by open coding that function (which has
various other disadvantages as well), but should be turned from silent breakage
either into non-breakage (and do so not only for sort() but for other generic
functions as well), or should be turned into a build failure.
Thanks,
Ingo
next prev parent reply other threads:[~2017-12-28 12:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 8:50 [PATCH v6 0/8] add support for relative references in special sections Ard Biesheuvel
2017-12-27 8:50 ` [PATCH v6 1/8] arch: enable relative relocations for arm64, power, x86, s390 and x86 Ard Biesheuvel
2017-12-27 19:54 ` Linus Torvalds
2017-12-27 19:59 ` Ard Biesheuvel
2017-12-27 8:50 ` [PATCH v6 2/8] module: use relative references for __ksymtab entries Ard Biesheuvel
2017-12-27 20:07 ` Linus Torvalds
2017-12-27 20:11 ` Ard Biesheuvel
2017-12-27 20:13 ` Linus Torvalds
2017-12-27 20:24 ` Ard Biesheuvel
2017-12-28 12:05 ` Ingo Molnar [this message]
2017-12-28 12:39 ` Ard Biesheuvel
2017-12-29 6:42 ` kbuild test robot
2017-12-27 8:50 ` [PATCH v6 3/8] init: allow initcall tables to be emitted using relative references Ard Biesheuvel
2017-12-27 8:50 ` [PATCH v6 4/8] PCI: Add support for relative addressing in quirk tables Ard Biesheuvel
2017-12-27 8:50 ` [PATCH v6 5/8] kernel: tracepoints: add support for relative references Ard Biesheuvel
2017-12-28 15:42 ` Steven Rostedt
2017-12-28 23:24 ` Ard Biesheuvel
2017-12-27 8:50 ` [PATCH v6 6/8] kernel/jump_label: abstract jump_entry member accessors Ard Biesheuvel
2017-12-27 8:50 ` [PATCH v6 7/8] arm64/kernel: jump_label: use relative references Ard Biesheuvel
2017-12-27 8:50 ` [PATCH v6 8/8] x86/kernel: jump_table: " Ard Biesheuvel
2017-12-28 16:19 ` Steven Rostedt
2017-12-28 16:26 ` Ard Biesheuvel
2017-12-28 16:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228120531.xhcb4dg2qu2z5ssp@gmail.com \
--to=mingo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox