* [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions
@ 2018-01-05 20:55 SF Markus Elfring
2018-01-08 0:58 ` Yang, Wenyou
0 siblings, 1 reply; 4+ messages in thread
From: SF Markus Elfring @ 2018-01-05 20:55 UTC (permalink / raw)
To: linux-arm-kernel
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 5 Jan 2018 21:45:04 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/mtd/nand/atmel/nand-controller.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
index 90a71a56bc23..a41b999229c9 100644
--- a/drivers/mtd/nand/atmel/nand-controller.c
+++ b/drivers/mtd/nand/atmel/nand-controller.c
@@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand)
mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL,
"%s:nand.%d", dev_name(nc->dev),
nand->cs[0].id);
- if (!mtd->name) {
- dev_err(nc->dev, "Failed to allocate mtd->name\n");
+ if (!mtd->name)
return -ENOMEM;
- }
}
ret = nand_scan_tail(mtd);
@@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc,
nand = devm_kzalloc(nc->dev,
sizeof(*nand) + (numcs * sizeof(*nand->cs)),
GFP_KERNEL);
- if (!nand) {
- dev_err(nc->dev, "Failed to allocate NAND object\n");
+ if (!nand)
return ERR_PTR(-ENOMEM);
- }
nand->numcs = numcs;
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions
2018-01-05 20:55 [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
@ 2018-01-08 0:58 ` Yang, Wenyou
2018-01-08 8:18 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Yang, Wenyou @ 2018-01-08 0:58 UTC (permalink / raw)
To: linux-arm-kernel
On 2018/1/6 4:55, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 5 Jan 2018 21:45:04 +0100
>
> Omit an extra message for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Acked-by: Wenyou Yang <wenyou.yang@microchip.com>
> drivers/mtd/nand/atmel/nand-controller.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> index 90a71a56bc23..a41b999229c9 100644
> --- a/drivers/mtd/nand/atmel/nand-controller.c
> +++ b/drivers/mtd/nand/atmel/nand-controller.c
> @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand)
> mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL,
> "%s:nand.%d", dev_name(nc->dev),
> nand->cs[0].id);
> - if (!mtd->name) {
> - dev_err(nc->dev, "Failed to allocate mtd->name\n");
> + if (!mtd->name)
> return -ENOMEM;
> - }
> }
>
> ret = nand_scan_tail(mtd);
> @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc,
> nand = devm_kzalloc(nc->dev,
> sizeof(*nand) + (numcs * sizeof(*nand->cs)),
> GFP_KERNEL);
> - if (!nand) {
> - dev_err(nc->dev, "Failed to allocate NAND object\n");
> + if (!nand)
> return ERR_PTR(-ENOMEM);
> - }
>
> nand->numcs = numcs;
>
Best Regards,
Wenyou Yang
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions
2018-01-08 0:58 ` Yang, Wenyou
@ 2018-01-08 8:18 ` Boris Brezillon
2018-01-08 8:33 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2018-01-08 8:18 UTC (permalink / raw)
To: linux-arm-kernel
[private message]
Hi Wenyou,
On Mon, 8 Jan 2018 08:58:21 +0800
"Yang, Wenyou" <Wenyou.Yang@Microchip.com> wrote:
> On 2018/1/6 4:55, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Fri, 5 Jan 2018 21:45:04 +0100
> >
> > Omit an extra message for a memory allocation failure in these functions.
> >
> > This issue was detected by using the Coccinelle software.
> >
> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > ---
>
> Acked-by: Wenyou Yang <wenyou.yang@microchip.com>
Please don't encourage Markus to send more patches. The MTD maintainers
(like other maintainers) have decided to ignore his contributions.
If you want to know why, just google his name and you should have a
pretty good idea.
Thanks,
Boris
> > drivers/mtd/nand/atmel/nand-controller.c | 8 ++------
> > 1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> > index 90a71a56bc23..a41b999229c9 100644
> > --- a/drivers/mtd/nand/atmel/nand-controller.c
> > +++ b/drivers/mtd/nand/atmel/nand-controller.c
> > @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand)
> > mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL,
> > "%s:nand.%d", dev_name(nc->dev),
> > nand->cs[0].id);
> > - if (!mtd->name) {
> > - dev_err(nc->dev, "Failed to allocate mtd->name\n");
> > + if (!mtd->name)
> > return -ENOMEM;
> > - }
> > }
> >
> > ret = nand_scan_tail(mtd);
> > @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc,
> > nand = devm_kzalloc(nc->dev,
> > sizeof(*nand) + (numcs * sizeof(*nand->cs)),
> > GFP_KERNEL);
> > - if (!nand) {
> > - dev_err(nc->dev, "Failed to allocate NAND object\n");
> > + if (!nand)
> > return ERR_PTR(-ENOMEM);
> > - }
> >
> > nand->numcs = numcs;
> >
>
> Best Regards,
> Wenyou Yang
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions
2018-01-08 8:18 ` Boris Brezillon
@ 2018-01-08 8:33 ` Boris Brezillon
0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-01-08 8:33 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 8 Jan 2018 09:18:31 +0100
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:
> [private message]
Oops, not so private :-).
> Hi Wenyou,
>
> On Mon, 8 Jan 2018 08:58:21 +0800
> "Yang, Wenyou" <Wenyou.Yang@Microchip.com> wrote:
>
> > On 2018/1/6 4:55, SF Markus Elfring wrote:
> > > From: Markus Elfring <elfring@users.sourceforge.net>
> > > Date: Fri, 5 Jan 2018 21:45:04 +0100
> > >
> > > Omit an extra message for a memory allocation failure in these functions.
> > >
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> > > ---
> >
> > Acked-by: Wenyou Yang <wenyou.yang@microchip.com>
>
> Please don't encourage Markus to send more patches. The MTD maintainers
> (like other maintainers) have decided to ignore his contributions.
>
> If you want to know why, just google his name and you should have a
> pretty good idea.
>
> Thanks,
>
> Boris
>
> > > drivers/mtd/nand/atmel/nand-controller.c | 8 ++------
> > > 1 file changed, 2 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c
> > > index 90a71a56bc23..a41b999229c9 100644
> > > --- a/drivers/mtd/nand/atmel/nand-controller.c
> > > +++ b/drivers/mtd/nand/atmel/nand-controller.c
> > > @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand)
> > > mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL,
> > > "%s:nand.%d", dev_name(nc->dev),
> > > nand->cs[0].id);
> > > - if (!mtd->name) {
> > > - dev_err(nc->dev, "Failed to allocate mtd->name\n");
> > > + if (!mtd->name)
> > > return -ENOMEM;
> > > - }
> > > }
> > >
> > > ret = nand_scan_tail(mtd);
> > > @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc,
> > > nand = devm_kzalloc(nc->dev,
> > > sizeof(*nand) + (numcs * sizeof(*nand->cs)),
> > > GFP_KERNEL);
> > > - if (!nand) {
> > > - dev_err(nc->dev, "Failed to allocate NAND object\n");
> > > + if (!nand)
> > > return ERR_PTR(-ENOMEM);
> > > - }
> > >
> > > nand->numcs = numcs;
> > >
> >
> > Best Regards,
> > Wenyou Yang
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-08 8:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-05 20:55 [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2018-01-08 0:58 ` Yang, Wenyou
2018-01-08 8:18 ` Boris Brezillon
2018-01-08 8:33 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).