From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Mon, 8 Jan 2018 09:33:37 +0100 Subject: [PATCH] mtd/nand/atmel: Delete an error message for a failed memory allocation in two functions In-Reply-To: <20180108091831.64d54599@bbrezillon> References: <81cadb76-8c67-9289-1375-2d4a55a4adfa@users.sourceforge.net> <09e98604-00ec-64be-665a-a101b31028b1@Microchip.com> <20180108091831.64d54599@bbrezillon> Message-ID: <20180108093337.3a9cb292@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 8 Jan 2018 09:18:31 +0100 Boris Brezillon wrote: > [private message] Oops, not so private :-). > Hi Wenyou, > > On Mon, 8 Jan 2018 08:58:21 +0800 > "Yang, Wenyou" wrote: > > > On 2018/1/6 4:55, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date: Fri, 5 Jan 2018 21:45:04 +0100 > > > > > > Omit an extra message for a memory allocation failure in these functions. > > > > > > This issue was detected by using the Coccinelle software. > > > > > > Signed-off-by: Markus Elfring > > > --- > > > > Acked-by: Wenyou Yang > > Please don't encourage Markus to send more patches. The MTD maintainers > (like other maintainers) have decided to ignore his contributions. > > If you want to know why, just google his name and you should have a > pretty good idea. > > Thanks, > > Boris > > > > drivers/mtd/nand/atmel/nand-controller.c | 8 ++------ > > > 1 file changed, 2 insertions(+), 6 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/atmel/nand-controller.c b/drivers/mtd/nand/atmel/nand-controller.c > > > index 90a71a56bc23..a41b999229c9 100644 > > > --- a/drivers/mtd/nand/atmel/nand-controller.c > > > +++ b/drivers/mtd/nand/atmel/nand-controller.c > > > @@ -1612,10 +1612,8 @@ static int atmel_nand_register(struct atmel_nand *nand) > > > mtd->name = devm_kasprintf(nc->dev, GFP_KERNEL, > > > "%s:nand.%d", dev_name(nc->dev), > > > nand->cs[0].id); > > > - if (!mtd->name) { > > > - dev_err(nc->dev, "Failed to allocate mtd->name\n"); > > > + if (!mtd->name) > > > return -ENOMEM; > > > - } > > > } > > > > > > ret = nand_scan_tail(mtd); > > > @@ -1654,10 +1652,8 @@ static struct atmel_nand *atmel_nand_create(struct atmel_nand_controller *nc, > > > nand = devm_kzalloc(nc->dev, > > > sizeof(*nand) + (numcs * sizeof(*nand->cs)), > > > GFP_KERNEL); > > > - if (!nand) { > > > - dev_err(nc->dev, "Failed to allocate NAND object\n"); > > > + if (!nand) > > > return ERR_PTR(-ENOMEM); > > > - } > > > > > > nand->numcs = numcs; > > > > > > > Best Regards, > > Wenyou Yang >