From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service
Date: Tue, 9 Jan 2018 15:41:35 +0200 [thread overview]
Message-ID: <20180109134135.32i6slkhmqsjnmne@tarshish> (raw)
In-Reply-To: <2013811470.181895.1514918984637@email.1und1.de>
Hi Stefan,
On Tue, Jan 02, 2018 at 07:49:44PM +0100, Stefan Wahren wrote:
[...]
> > + ret = rpi_firmware_property(gpio->fw, RPI_FIRMWARE_GET_GPIO_CONFIG,
> > + &get, sizeof(get));
> > + if (ret) {
> > + dev_err(gpio->dev,
> > + "Failed to get GPIO %u config (%d)\n", off, ret);
> > + return ret;
> > + }
>
> Shouldn't we also check the in-bound status at get.gpio?
What is the in-bound status value? May you refer me to the documentation?
> And in all the other gpio ops?
Thanks,
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2018-01-09 13:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 13:19 [PATCH 0/4] gpio: driver for the RPi3 GPIO expander Baruch Siach
2018-01-02 13:19 ` [PATCH 1/4] ARM: bcm2835: sync firmware properties with downstream Baruch Siach
2018-01-02 13:19 ` [PATCH 2/4] dt-bindings: gpio: add raspberry pi GPIO expander binding Baruch Siach
2018-01-02 18:26 ` Stefan Wahren
2018-01-04 19:35 ` Baruch Siach
2018-01-02 13:19 ` [PATCH 3/4] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service Baruch Siach
2018-01-02 18:49 ` Stefan Wahren
2018-01-09 13:41 ` Baruch Siach [this message]
2018-01-09 20:15 ` Stefan Wahren
2018-01-03 10:08 ` Linus Walleij
2018-01-10 3:45 ` Baruch Siach
2018-01-11 9:39 ` Linus Walleij
2018-01-02 13:19 ` [PATCH 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander Baruch Siach
2018-01-02 19:03 ` Stefan Wahren
2018-01-03 20:17 ` Stefan Wahren
2018-01-03 20:29 ` Phil Elwell
2018-01-04 3:06 ` Peter Robinson
2018-01-02 18:05 ` [PATCH 0/4] gpio: driver for the RPi3 " Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109134135.32i6slkhmqsjnmne@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox