From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@free-electrons.com (Boris Brezillon) Date: Wed, 10 Jan 2018 17:23:20 +0100 Subject: [PATCH] crypto: marvell/cesa - Fix DMA API misuse In-Reply-To: <20180110154817.GA18707@lst.de> References: <55d3177407b00dd4a9d51fe4f8e2bf2282fe8e3d.1515596541.git.robin.murphy@arm.com> <20180110162522.580089a5@bbrezillon> <20180110154817.GA18707@lst.de> Message-ID: <20180110172320.5ab39e43@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Christoph, On Wed, 10 Jan 2018 16:48:17 +0100 Christoph Hellwig wrote: > On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote: > > On Wed, 10 Jan 2018 15:15:43 +0000 > > Robin Murphy wrote: > > > > > phys_to_dma() is an internal helper for certain DMA API implementations, > > > and is not appropriate for drivers to use. It appears that what the CESA > > > driver really wants to be using is dma_map_resource() - admittedly that > > > didn't exist when the offending code was first merged, but it does now. > > > > > > Signed-off-by: Robin Murphy > > > > Acked-by: Boris Brezillon > > Thanks. Robin, Boris: do you want me to pick this up in the > dma-mapping tree and move it before the dma-direct.h introduction? You should probably sync with Herbert, I'm just the maintainer of this driver, not the crypto subsystem. Regards, Boris