linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] soc: brcmstb: Only register SoC device on STB platforms
Date: Thu, 11 Jan 2018 17:01:30 -0800	[thread overview]
Message-ID: <20180112010130.3tz7hnmzs74trwhw@localhost> (raw)
In-Reply-To: <20180109145409.11612-1-thierry.reding@gmail.com>

On Tue, Jan 09, 2018 at 03:54:09PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> After moving the SoC device initialization to an early initcall in
> commit f780429adfbc ("soc: brcmstb: biuctrl: Move to early_initcall"),
> the Broadcom STB SoC device is registered on all platforms if support
> for the device is enabled in the kernel configuration.
> 
> This causes an additional SoC device to appear on platforms that already
> register a native one. In case of Tegra the STB SoC device is registered
> as soc0 (with totally meaningless content in the sysfs attributes) and
> causes various scripts and programs to fail because they don't know how
> to parse that data.
> 
> To fix this, duplicate the check from brcmstb_soc_device_early_init()
> that already prevents the code from doing anything nonsensical on non-
> STB platforms.
> 
> Fixes: f780429adfbc ("soc: brcmstb: biuctrl: Move to early_initcall")
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---


Thanks, applied.


-Olof

  reply	other threads:[~2018-01-12  1:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 14:54 [PATCH] soc: brcmstb: Only register SoC device on STB platforms Thierry Reding
2018-01-12  1:01 ` Olof Johansson [this message]
2018-01-12  1:03   ` Florian Fainelli
2018-01-12 11:39 ` Sudeep Holla
2018-01-12 12:12   ` Sudeep Holla
2018-01-12 12:58     ` Thierry Reding
2018-01-12 13:15       ` Thierry Reding
2018-01-12 15:25         ` Sudeep Holla
2018-01-12 15:27       ` Sudeep Holla
2018-01-12 18:19         ` Olof Johansson
2018-01-12 18:21           ` Olof Johansson
2018-01-12 18:27             ` Florian Fainelli
2018-01-12 18:30               ` Olof Johansson
2018-01-12 18:34     ` Florian Fainelli
2018-01-12 12:56   ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180112010130.3tz7hnmzs74trwhw@localhost \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).