From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Fri, 12 Jan 2018 09:37:49 +0100 Subject: [linux-sunxi] Re: [PATCH v5 2/2] media: V3s: Add support for Allwinner CSI. In-Reply-To: <20180112095114.b2414fe44cff7bf7cf6f8822@magewell.com> References: <1515639966-35902-1-git-send-email-yong.deng@magewell.com> <20180111132844.mok7upqjycpx3bqm@flea.lan> <20180112095114.b2414fe44cff7bf7cf6f8822@magewell.com> Message-ID: <20180112083749.syxtwiigxafxw4zq@flea.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 12, 2018 at 09:51:14AM +0800, Yong wrote: > Hi Maxime, > > On Thu, 11 Jan 2018 14:28:44 +0100 > Maxime Ripard wrote: > > > Hi Yong, > > > > On Thu, Jan 11, 2018 at 11:06:06AM +0800, Yong Deng wrote: > > > Allwinner V3s SoC features two CSI module. CSI0 is used for MIPI CSI-2 > > > interface and CSI1 is used for parallel interface. This is not > > > documented in datasheet but by test and guess. > > > > > > This patch implement a v4l2 framework driver for it. > > > > > > Currently, the driver only support the parallel interface. MIPI-CSI2, > > > ISP's support are not included in this patch. > > > > > > Signed-off-by: Yong Deng > > > > I've needed this patch in order to fix a NULL pointer dereference: > > http://code.bulix.org/oz6gmb-257359?raw > > > > This is needed because while it's ok to have a NULL pointer to > > v4l2_subdev_pad_config when you call the subdev set_fmt with > > V4L2_SUBDEV_FORMAT_ACTIVE, it's not with V4L2_SUBDEV_FORMAT_TRY, and > > sensors will assume taht it's a valid pointer. > > > > Otherwise, > > Tested-by: Maxime Ripard > > I revisit some code of subdevs and you are right. > > Squash your patch into my driver patch and add your Tested-by in > commit. Is it right? Yep, that's perfect :) Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: