From: dan.carpenter@oracle.com (Dan Carpenter)
To: linux-arm-kernel@lists.infradead.org
Subject: [bug report] perf: ARM DynamIQ Shared Unit PMU support
Date: Fri, 12 Jan 2018 23:13:34 +0300 [thread overview]
Message-ID: <20180112201334.sfqjnyw4or4msfeq@mwanda> (raw)
Hello Suzuki K Poulose,
The patch 7520fa99246d: "perf: ARM DynamIQ Shared Unit PMU support"
from Jan 2, 2018, leads to the following static checker warning:
drivers/perf/arm_dsu_pmu.c:680 dsu_pmu_init_pmu()
warn: impossible condition '(dsu_pmu->num_counters == -1) => (0-255 == (-1))'
drivers/perf/arm_dsu_pmu.c
674 /*
675 * dsu_pmu_init_pmu: Initialise the DSU PMU configurations if
676 * we haven't done it already.
677 */
678 static void dsu_pmu_init_pmu(struct dsu_pmu *dsu_pmu)
679 {
680 if (dsu_pmu->num_counters == -1)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
A u8 variable can't ever be -1.
681 dsu_pmu_probe_pmu(dsu_pmu);
682 /* Reset the interrupt overflow mask */
683 dsu_pmu_get_reset_overflow();
684 }
regards,
dan carpenter
next reply other threads:[~2018-01-12 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 20:13 Dan Carpenter [this message]
2018-01-15 10:51 ` [bug report] perf: ARM DynamIQ Shared Unit PMU support Suzuki K Poulose
2018-01-15 18:02 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112201334.sfqjnyw4or4msfeq@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox