From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: i2c: Include GPIO consumer header in main include
Date: Mon, 15 Jan 2018 19:03:03 +0100 [thread overview]
Message-ID: <20180115180303.pdax5amdj2rtytih@ninjato> (raw)
In-Reply-To: <20171208133934.18038-1-linus.walleij@linaro.org>
On Fri, Dec 08, 2017 at 02:39:34PM +0100, Linus Walleij wrote:
> It seems most users of <linux/i2c.h> pick up their
> dependency of <linux/gpio/consumer.h> from other paths but
> that is not a universal law, so include the header
> explicitly so we have struct gpio_desc available.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
I still think drivers needing GPIO should include it explicitly.
So, NAK until further arguments arrive...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180115/11fd1e6e/attachment.sig>
prev parent reply other threads:[~2018-01-15 18:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-08 13:39 [PATCH] i2c: Include GPIO consumer header in main include Linus Walleij
2017-12-12 22:33 ` Wolfram Sang
2018-01-15 18:03 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115180303.pdax5amdj2rtytih@ninjato \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox