From: joro@8bytes.org (Joerg Roedel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message
Date: Wed, 17 Jan 2018 20:23:01 +0100 [thread overview]
Message-ID: <20180117192301.GV28161@8bytes.org> (raw)
In-Reply-To: <66706458-d971-be9b-4390-80a9be39248c@arm.com>
On Wed, Jan 17, 2018 at 07:08:39PM +0000, Marc Zyngier wrote:
> On 17/01/18 18:54, Robin Murphy wrote:
> Indeed. How about checking dev->msi_domain first, which should tell you
> whether it is even possible to allocate MSIs, and fallback to wired IRQs
> instead. That way, we keep the warning on genuine failures to allocate
> MSIs, and you get to add a nice "Falling back to wired interrupts"
> message when msi_domain is NULL.
>
> Thoughts?
That sounds much better then the proposed patch. I am not really interested
in changing log-levels to make test-tools happy.
Joerg
prev parent reply other threads:[~2018-01-17 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:39 [PATCH] iommu/arm-smmu-v3: suppress MSI allocation failure message Nate Watterson
2018-01-17 18:54 ` Robin Murphy
2018-01-17 19:08 ` Marc Zyngier
2018-01-17 19:23 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117192301.GV28161@8bytes.org \
--to=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).