* [PATCH 4/5] arm64: dts: renesas: r8a77970: add LVDS support
@ 2018-01-19 19:42 Sergei Shtylyov
2018-01-19 20:13 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2018-01-19 19:42 UTC (permalink / raw)
To: linux-arm-kernel
Define the generic R8A77970 part of the LVDS device node.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
arch/arm64/boot/dts/renesas/r8a77970.dtsi | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
Index: renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
===================================================================
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -654,6 +654,31 @@
port at 1 {
reg = <1>;
du_out_lvds: endpoint {
+ remote-endpoint = <&lvds_in>;
+ };
+ };
+ };
+ };
+
+ lvds: lvds at feb90000 {
+ compatible = "renesas,r8a77970-lvds";
+ reg = <0 0xfeb90000 0 0x14>;
+ clocks = <&cpg CPG_MOD 727>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port at 0 {
+ reg = <0>;
+ lvds_in: endpoint {
+ remote-endpoint = <&du_out_lvds>;
+ };
+ };
+ port at 1 {
+ reg = <1>;
+ lvds_out: endpoint {
};
};
};
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 4/5] arm64: dts: renesas: r8a77970: add LVDS support
2018-01-19 19:42 [PATCH 4/5] arm64: dts: renesas: r8a77970: add LVDS support Sergei Shtylyov
@ 2018-01-19 20:13 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-01-19 20:13 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sergei,
On Fri, Jan 19, 2018 at 8:42 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the generic R8A77970 part of the LVDS device node.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
I love your patch! Yet something to improve...
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -654,6 +654,31 @@
> port at 1 {
> reg = <1>;
> du_out_lvds: endpoint {
> + remote-endpoint = <&lvds_in>;
> + };
> + };
> + };
> + };
> +
> + lvds: lvds at feb90000 {
> + compatible = "renesas,r8a77970-lvds";
> + reg = <0 0xfeb90000 0 0x14>;
> + clocks = <&cpg CPG_MOD 727>;
Missing resets and power-domains properties.
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port at 0 {
> + reg = <0>;
> + lvds_in: endpoint {
> + remote-endpoint = <&du_out_lvds>;
> + };
> + };
> + port at 1 {
> + reg = <1>;
> + lvds_out: endpoint {
> };
> };
> };
>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19 19:42 [PATCH 4/5] arm64: dts: renesas: r8a77970: add LVDS support Sergei Shtylyov
2018-01-19 20:13 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).