* [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
@ 2018-01-29 9:22 codekipper at gmail.com
2018-01-29 10:22 ` Maxime Ripard
0 siblings, 1 reply; 6+ messages in thread
From: codekipper at gmail.com @ 2018-01-29 9:22 UTC (permalink / raw)
To: linux-arm-kernel
From: Marcus Cooper <codekipper@gmail.com>
Add the new DAI block for I2S2 which is used for HDMI audio.
Signed-off-by: Marcus Cooper <codekipper@gmail.com>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 7a83b15225c7..238e7007d5b9 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -568,6 +568,19 @@
status = "disabled";
};
+ i2s2: i2s at 1c22800 {
+ #sound-dai-cells = <0>;
+ compatible = "allwinner,sun8i-h3-i2s";
+ reg = <0x01c22800 0x400>;
+ interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&ccu CLK_BUS_I2S2>, <&ccu CLK_I2S2>;
+ clock-names = "apb", "mod";
+ dmas = <&dma 27>;
+ resets = <&ccu RST_BUS_I2S2>;
+ dma-names = "tx";
+ status = "disabled";
+ };
+
codec: codec at 1c22c00 {
#sound-dai-cells = <0>;
compatible = "allwinner,sun8i-h3-codec";
--
2.16.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
2018-01-29 9:22 [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI codekipper at gmail.com
@ 2018-01-29 10:22 ` Maxime Ripard
2018-01-29 10:35 ` Jernej Škrabec
0 siblings, 1 reply; 6+ messages in thread
From: Maxime Ripard @ 2018-01-29 10:22 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper at gmail.com wrote:
> From: Marcus Cooper <codekipper@gmail.com>
>
> Add the new DAI block for I2S2 which is used for HDMI audio.
>
> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
queued for 4.17, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180129/77cb52ff/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
2018-01-29 10:22 ` Maxime Ripard
@ 2018-01-29 10:35 ` Jernej Škrabec
2018-01-31 7:16 ` maxime ripard
0 siblings, 1 reply; 6+ messages in thread
From: Jernej Škrabec @ 2018-01-29 10:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Maxime,
(previously I respond only to linux-sunxi mailing list)
>On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper at gmail.com wrote:
>> From: Marcus Cooper <codekipper@gmail.com>
>>
>> Add the new DAI block for I2S2 which is used for HDMI audio.
>>
>> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
>
>queued for 4.17, thanks!
>Maxime
Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
supports 8 channel audio. As Marcus said, other blocks probably
support them too, they are just not wired out on pins.
Should we change compatible for HDMI?
Best regards,
Jernej
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
2018-01-29 10:35 ` Jernej Škrabec
@ 2018-01-31 7:16 ` maxime ripard
2018-01-31 9:54 ` Code Kipper
0 siblings, 1 reply; 6+ messages in thread
From: maxime ripard @ 2018-01-31 7:16 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej ?krabec wrote:
> Hi Maxime,
>
> (previously I respond only to linux-sunxi mailing list)
>
> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper at gmail.com wrote:
> >> From: Marcus Cooper <codekipper@gmail.com>
> >>
> >> Add the new DAI block for I2S2 which is used for HDMI audio.
> >>
> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> >
> >queued for 4.17, thanks!
> >Maxime
>
> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
> supports 8 channel audio. As Marcus said, other blocks probably
> support them too, they are just not wired out on pins.
I've dropped those patches for now.
> Should we change compatible for HDMI?
I guess, another way of doing things if they are strictly identical
but for the number of lanes they support would be to add a DT property
for that number of lanes.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180131/36d6c694/attachment-0001.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
2018-01-31 7:16 ` maxime ripard
@ 2018-01-31 9:54 ` Code Kipper
2018-01-31 15:57 ` maxime ripard
0 siblings, 1 reply; 6+ messages in thread
From: Code Kipper @ 2018-01-31 9:54 UTC (permalink / raw)
To: linux-arm-kernel
On 31 January 2018 at 08:16, maxime ripard
<maxime.ripard@free-electrons.com> wrote:
> On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej ?krabec wrote:
>> Hi Maxime,
>>
>> (previously I respond only to linux-sunxi mailing list)
>>
>> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper at gmail.com wrote:
>> >> From: Marcus Cooper <codekipper@gmail.com>
>> >>
>> >> Add the new DAI block for I2S2 which is used for HDMI audio.
>> >>
>> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
>> >
>> >queued for 4.17, thanks!
>> >Maxime
>>
>> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
>> supports 8 channel audio. As Marcus said, other blocks probably
>> support them too, they are just not wired out on pins.
>
> I've dropped those patches for now.
>
>> Should we change compatible for HDMI?
>
> I guess, another way of doing things if they are strictly identical
> but for the number of lanes they support would be to add a DT property
> for that number of lanes.
>
That's fine...I'll look into adding a dt property and how we would map
channels to lanes.
Do you know of any examples?,
BR,
CK
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI
2018-01-31 9:54 ` Code Kipper
@ 2018-01-31 15:57 ` maxime ripard
0 siblings, 0 replies; 6+ messages in thread
From: maxime ripard @ 2018-01-31 15:57 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 31, 2018 at 10:54:29AM +0100, Code Kipper wrote:
> On 31 January 2018 at 08:16, maxime ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Mon, Jan 29, 2018 at 11:35:27AM +0100, Jernej ?krabec wrote:
> >> Hi Maxime,
> >>
> >> (previously I respond only to linux-sunxi mailing list)
> >>
> >> >On Mon, Jan 29, 2018 at 10:22:23AM +0100, codekipper at gmail.com wrote:
> >> >> From: Marcus Cooper <codekipper@gmail.com>
> >> >>
> >> >> Add the new DAI block for I2S2 which is used for HDMI audio.
> >> >>
> >> >> Signed-off-by: Marcus Cooper <codekipper@gmail.com>
> >> >
> >> >queued for 4.17, thanks!
> >> >Maxime
> >>
> >> Please note that HDMI I2S has usable 4 I2S lanes, since HDMI
> >> supports 8 channel audio. As Marcus said, other blocks probably
> >> support them too, they are just not wired out on pins.
> >
> > I've dropped those patches for now.
> >
> >> Should we change compatible for HDMI?
> >
> > I guess, another way of doing things if they are strictly identical
> > but for the number of lanes they support would be to add a DT property
> > for that number of lanes.
> >
> That's fine...I'll look into adding a dt property and how we would map
> channels to lanes.
> Do you know of any examples?,
Grepping for of_property_read_u32 should give you plenty of examples :)
maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180131/c2a55199/attachment-0001.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-31 15:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-29 9:22 [linux-sunxi][PATCH] ARM: dts: sunxi: h3/h5: Add DAI node for HDMI codekipper at gmail.com
2018-01-29 10:22 ` Maxime Ripard
2018-01-29 10:35 ` Jernej Škrabec
2018-01-31 7:16 ` maxime ripard
2018-01-31 9:54 ` Code Kipper
2018-01-31 15:57 ` maxime ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).