* [PATCH] PCI: exynos: fix the potential null pointer dereference
2018-01-22 2:28 ` [PATCH] PCI: exynos: fix the potential null pointer dereference Jaehoon Chung
@ 2018-01-22 16:52 ` Jingoo Han
2018-01-29 17:10 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2018-01-22 16:52 UTC (permalink / raw)
To: linux-arm-kernel
On Sunday, January 21, 2018 6:29 PM, Jaehoon Chung wrote:
>
> Before calling the callback function, it needs to check whether
> init_clk_resources is assigned or not.
> Otherwise, it can be occurred the NULL pointer dereference when
> init_clk_resources is not assigned.
>
> Even though init_clk_resources is assigned now, it needs to prevent the
> potential NULL pointer dereference in future.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Acked-by: Jingoo Han <jingoohan1@gmail.com>
Best regards,
Jingoo Han
> ---
> drivers/pci/dwc/pci-exynos.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c
> index 56f32aeebd0a..39f08881f9a4 100644
> --- a/drivers/pci/dwc/pci-exynos.c
> +++ b/drivers/pci/dwc/pci-exynos.c
> @@ -499,7 +499,8 @@ static int __init exynos_pcie_probe(struct
> platform_device *pdev)
> return ret;
> }
>
> - if (ep->ops && ep->ops->get_clk_resources) {
> + if (ep->ops && ep->ops->get_clk_resources &&
> + ep->ops->init_clk_resources) {
> ret = ep->ops->get_clk_resources(ep);
> if (ret)
> return ret;
> --
> 2.15.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] PCI: exynos: fix the potential null pointer dereference
2018-01-22 2:28 ` [PATCH] PCI: exynos: fix the potential null pointer dereference Jaehoon Chung
2018-01-22 16:52 ` Jingoo Han
@ 2018-01-29 17:10 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2018-01-29 17:10 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Jan 22, 2018 at 11:28:54AM +0900, Jaehoon Chung wrote:
> Before calling the callback function, it needs to check whether
> init_clk_resources is assigned or not.
> Otherwise, it can be occurred the NULL pointer dereference when
> init_clk_resources is not assigned.
>
> Even though init_clk_resources is assigned now, it needs to prevent the
> potential NULL pointer dereference in future.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/pci/dwc/pci-exynos.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/dwc/pci-exynos.c b/drivers/pci/dwc/pci-exynos.c
> index 56f32aeebd0a..39f08881f9a4 100644
> --- a/drivers/pci/dwc/pci-exynos.c
> +++ b/drivers/pci/dwc/pci-exynos.c
> @@ -499,7 +499,8 @@ static int __init exynos_pcie_probe(struct platform_device *pdev)
> return ret;
> }
>
> - if (ep->ops && ep->ops->get_clk_resources) {
> + if (ep->ops && ep->ops->get_clk_resources &&
> + ep->ops->init_clk_resources) {
> ret = ep->ops->get_clk_resources(ep);
> if (ret)
> return ret;
> --
> 2.15.1
I applied it to pci/dwc for 4.16.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread