public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: sunxi-ng: ccu-sun4i-a10: Fix mali changing dclk frequency
Date: Wed, 31 Jan 2018 09:43:49 +0100	[thread overview]
Message-ID: <20180131084349.du2ijvhh5rxa5vvt@flea.lan> (raw)
In-Reply-To: <1517354639-92978-1-git-send-email-giulio.benetti@micronovasrl.com>

Hi,

On Wed, Jan 31, 2018 at 12:23:59AM +0100, Giulio Benetti wrote:
> When mali.ko is inserted, it set default clocks and call all parent
> clocks to stay into range, causing pll-video0 to change and
> subsequently to change dclk to wrong frequencies.

This is what you should fix.

> "gpu" clock has lot of parent plls inside driver, but on sun7i
> pll8-gpu does not depend on pll-video0, pll-ve, pll-video1.
>
> It only depends on 24Mhz main clock.

I don't really know why you are mentionning that. The GPU clock has
all the parents described in the driver. And the parents' parents are
irrelevant to this particular issue.

> Remove all pll parents from gpu_parents_sun7i except "pll-gpu".

However, this is not a proper fix for your issue.

What kernel version did you use?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180131/f36c9a5b/attachment.sig>

  reply	other threads:[~2018-01-31  8:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 23:23 [PATCH] clk: sunxi-ng: ccu-sun4i-a10: Fix mali changing dclk frequency Giulio Benetti
2018-01-31  8:43 ` Maxime Ripard [this message]
2018-01-31 12:05   ` Giulio Benetti
2018-02-01 12:45     ` Maxime Ripard
2018-02-01 16:17       ` Giulio Benetti
2018-02-02 10:53         ` Maxime Ripard
2018-02-02 10:57           ` Giulio Benetti
2018-02-02 13:35             ` Maxime Ripard
2018-02-02 15:38               ` Giulio Benetti
2018-02-02 15:52                 ` Maxime Ripard
2018-02-02 17:21                   ` Giulio Benetti
2018-02-02 21:59                     ` Maxime Ripard
2018-02-02 22:46                       ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180131084349.du2ijvhh5rxa5vvt@flea.lan \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox