From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: sunxi-ng: ccu-sun4i-a10: Fix mali changing dclk frequency
Date: Fri, 2 Feb 2018 16:52:52 +0100 [thread overview]
Message-ID: <20180202155252.vhlih33ju6zh26oh@flea.lan> (raw)
In-Reply-To: <aa43a02a-3ea9-2f61-eaf6-ddc7980f78a5@micronovasrl.com>
On Fri, Feb 02, 2018 at 04:38:13PM +0100, Giulio Benetti wrote:
> Hi,
>
> Il 02/02/2018 14:35, Maxime Ripard ha scritto:
> > On Fri, Feb 02, 2018 at 11:57:20AM +0100, Giulio Benetti wrote:
> > > Il 02/02/2018 11:53, Maxime Ripard ha scritto:
> > > > Hi,
> > > >
> > > > On Thu, Feb 01, 2018 at 05:17:11PM +0100, Giulio Benetti wrote:
> > > > > > > > What kernel version did you use?
> > > > > > >
> > > > > > > Latest mainline.
> > > > > >
> > > > > > I guess this patch could fix it:
> > > > > > http://code.bulix.org/1kitrq-268936?raw
> > > > >
> > > > > This should prevent from modifying parent clock. But my problem was
> > > > > different.
> > > > >
> > > > > On A20, gpu_clk can have different PLL, not I've found out the way
> > > > > to choose right one with assigned-parent-clocks.
> > > > >
> > > > > I have patchset ready for adding A20 mali node, but I need some more
> > > > > time to complete with OPP, then I will submit entire patchset.
> > > > >
> > > > > Now it works correctly, using right pll(dedicated PLL8), setting
> > > > > right frequency.
> > > >
> > > > The point is that we really don't care about which PLL is actually
> > > > being used, as long as the rate is correct and we don't break anything
> > > > else. If the GPU rate is accessible through one of the other PLL, it
> > > > makes even more sense to not use the GPU PLL and keep it disabled,
> > > > since it will result in some power savings.
> > >
> > > Ah! I see the point now, very clever system for power saving.
> > > I'm going to check if it's resolutive,
> > > but it sounds good.
> > >
> > > >
> > > > > Btw, do I need to add a board using it, or can I add only Mali node
> > > > > to sun7i-a20.dtsi(plus other little patches)?
> > > >
> > > > You can add it to the DTSI without a board using it (and actually,
> > > > nothing should be in the board DTS, everything in the DT for the Mali
> > > > applies to all boards).
> > >
> > > Sure. So I would also add the patch you've addressed me:
> > > http://code.bulix.org/1kitrq-268936?raw
> > > as a commit. Can I submit it in patchset to complete the whole job?
> >
> > I already sent that patch quite some time ago, I'll just apply it. You
> > can send the DT patch :)
>
> Thanks. Sorry for my ignorance, but where are you applying patches?
> Because I've tried to check sunxi-next and a lot of other Repo but I can't
> find this and neither "Re: [PATCH] clk: sunxi-ng: ccu-sun4i-a10: Fix mali
> changing dclk frequency"
Usually, in the git tree listed in MAINTAINERS :)
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180202/5e2378dc/attachment.sig>
next prev parent reply other threads:[~2018-02-02 15:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 23:23 [PATCH] clk: sunxi-ng: ccu-sun4i-a10: Fix mali changing dclk frequency Giulio Benetti
2018-01-31 8:43 ` Maxime Ripard
2018-01-31 12:05 ` Giulio Benetti
2018-02-01 12:45 ` Maxime Ripard
2018-02-01 16:17 ` Giulio Benetti
2018-02-02 10:53 ` Maxime Ripard
2018-02-02 10:57 ` Giulio Benetti
2018-02-02 13:35 ` Maxime Ripard
2018-02-02 15:38 ` Giulio Benetti
2018-02-02 15:52 ` Maxime Ripard [this message]
2018-02-02 17:21 ` Giulio Benetti
2018-02-02 21:59 ` Maxime Ripard
2018-02-02 22:46 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202155252.vhlih33ju6zh26oh@flea.lan \
--to=maxime.ripard@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox