From: jernej.skrabec@siol.net (Jernej Skrabec)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 03/12] drm/bridge/synopsys: dw-hdmi: Enable workaround for v1.32a
Date: Wed, 7 Feb 2018 22:17:04 +0100 [thread overview]
Message-ID: <20180207211713.3638-4-jernej.skrabec@siol.net> (raw)
In-Reply-To: <20180207211713.3638-1-jernej.skrabec@siol.net>
Allwinner SoCs have dw hdmi controller v1.32a which exhibits same
magenta line issue as i.MX6Q and i.MX6DL. Enable workaround for it.
Tests show that one iteration is enough.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index a38db40ce990..7ca14d7325b5 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1634,9 +1634,10 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
* then write one of the FC registers several times.
*
* The number of iterations matters and depends on the HDMI TX revision
- * (and possibly on the platform). So far only i.MX6Q (v1.30a) and
- * i.MX6DL (v1.31a) have been identified as needing the workaround, with
- * 4 and 1 iterations respectively.
+ * (and possibly on the platform). So far i.MX6Q (v1.30a), i.MX6DL
+ * (v1.31a) and multiple Allwinner SoCs (v1.32a) have been identified
+ * as needing the workaround, with 4 iterations for v1.30a and 1
+ * iteration for others.
*/
switch (hdmi->version) {
@@ -1644,6 +1645,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
count = 4;
break;
case 0x131a:
+ case 0x132a:
count = 1;
break;
default:
--
2.16.1
next prev parent reply other threads:[~2018-02-07 21:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 21:17 [PATCH v4 00/12] drm/sun4i: Add A83T HDMI support Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 01/12] clk: sunxi-ng: Mask nkmp factors when setting register Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 02/12] clk: sunxi-ng: Use u64 for calculation of nkmp rate Jernej Skrabec
2018-02-08 8:03 ` Maxime Ripard
2018-02-07 21:17 ` Jernej Skrabec [this message]
2018-02-07 21:17 ` [PATCH v4 04/12] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber drvdata Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 06/12] dt-bindings: display: sun4i-drm: Add A83T HDMI pipeline Jernej Skrabec
2018-02-13 23:29 ` Rob Herring
2018-02-07 21:17 ` [PATCH v4 07/12] drm/sun4i: Add has_channel_0 TCON quirk Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 08/12] drm/sun4i: Add support for A83T second TCON Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 09/12] drm/sun4i: Add support for A83T second DE2 mixer Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 10/12] drm/sun4i: Implement A83T HDMI driver Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 11/12] ARM: dts: sun8i: a83t: Add HDMI display pipeline Jernej Skrabec
2018-02-07 21:17 ` [PATCH v4 12/12] ARM: dts: sun8i: a83t: Enable HDMI on BananaPi M3 Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207211713.3638-4-jernej.skrabec@siol.net \
--to=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox