From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Thu, 8 Feb 2018 14:47:10 +0800 Subject: [PATCH v2 1/2] soc: imx: gpcv2: Do not pass static memory as platform data In-Reply-To: <20180122150748.1742-1-andrew.smirnov@gmail.com> References: <20180122150748.1742-1-andrew.smirnov@gmail.com> Message-ID: <20180208064709.GB31910@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jan 22, 2018 at 07:07:47AM -0800, Andrey Smirnov wrote: > Platform device core assumes the ownership of dev.platform_data as > well as that it is dynamically allocated and it will try to kfree it > as a part of platform_device_release(). Change the code to pass > kzalloc'ed chunk of memory instead of a pointer to a static memory to > avoid causing a BUG() when calling platform_device_put(). > > The problem can be reproduced by artificially enabling the error path > of platform_device_add() call (around line 357). > > Note that this change also allows us to constify imx7_pgc_domains, > since we no longer need to be able to modify it. > > Cc: Shawn Guo > Cc: Stefan Agner > Cc: Lucas Stach > Cc: linux-arm-kernel at lists.infradead.org > Cc: linux-kernel at vger.kernel.org > Signed-off-by: Andrey Smirnov Applied both, thanks.