From: gnomes@lxorguk.ukuu.org.uk (Alan Cox)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/9] perf utils: add support for arch standard events
Date: Thu, 8 Feb 2018 14:02:50 +0000 [thread overview]
Message-ID: <20180208140250.43a10b84@alans-desktop> (raw)
In-Reply-To: <20180208135423.GC10234@krava>
On Thu, 8 Feb 2018 14:54:23 +0100
Jiri Olsa <jolsa@redhat.com> wrote:
> On Wed, Feb 07, 2018 at 01:45:00AM +0800, John Garry wrote:
>
> SNIP
>
> > static void print_events_table_suffix(FILE *outfp)
> > {
> > fprintf(outfp, "{\n");
> > @@ -407,6 +469,52 @@ static char *real_event(const char *name, char *event)
> > return event;
> > }
> >
> > +static void fixup_field(char *from, char **to)
> > +{
> > + *to = malloc(strlen(from));
> > +
> > + strcpy(*to, from);
> > +}
>
> could you just call '*to = strdup(from)' in here?
And check for malloc returning NULL.
Alan
next prev parent reply other threads:[~2018-02-08 14:02 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 17:44 [PATCH 0/9] perf events patches for improved ARM64 support John Garry
2018-02-06 17:44 ` [PATCH 1/9] perf vendor events: drop incomplete multiple mapfile support John Garry
2018-02-08 13:55 ` Jiri Olsa
2018-02-06 17:44 ` [PATCH 2/9] perf utils: add support for pmu events vendor sub-directory John Garry
2018-02-08 13:55 ` Jiri Olsa
2018-02-06 17:44 ` [PATCH 3/9] perf vendor events arm64: Relocate ThunderX2 JSON John Garry
2018-02-06 17:44 ` [PATCH 4/9] perf vendor events arm64: Relocate Cortex A53 JSONs John Garry
2018-02-06 17:45 ` [PATCH 5/9] perf utils: add support for arch standard events John Garry
2018-02-08 13:54 ` Jiri Olsa
2018-02-08 15:57 ` John Garry
2018-02-08 13:54 ` Jiri Olsa
2018-02-08 13:54 ` Jiri Olsa
2018-02-08 14:02 ` Alan Cox [this message]
2018-02-08 15:31 ` John Garry
2018-02-08 13:54 ` Jiri Olsa
2018-02-08 13:54 ` Jiri Olsa
2018-02-08 13:54 ` Jiri Olsa
2018-02-08 13:55 ` Jiri Olsa
2018-02-08 14:45 ` John Garry
2018-02-08 14:54 ` Jiri Olsa
2018-02-08 13:55 ` Jiri Olsa
2018-02-08 13:55 ` Jiri Olsa
2018-02-08 15:25 ` John Garry
2018-02-09 8:53 ` Jiri Olsa
2018-02-08 13:55 ` Jiri Olsa
2018-02-08 14:59 ` John Garry
2018-02-06 17:45 ` [PATCH 6/9] perf utils: add armv8-recommended.json John Garry
2018-02-06 17:45 ` [PATCH 7/9] perf utils: fixup Cavium ThunderX2 JSON to use ARMv8 recommended events John Garry
2018-02-06 17:45 ` [PATCH 8/9] perf utils: fixup ARM Cortex A53 JSONs " John Garry
2018-02-06 17:45 ` [PATCH 9/9] perf utils: add HiSilicon hip08 JSON file John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208140250.43a10b84@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).