From mboxrd@z Thu Jan 1 00:00:00 1970 From: wsa@the-dreams.de (Wolfram Sang) Date: Mon, 12 Feb 2018 11:54:56 +0100 Subject: [RFC v4 13/26] watchdog: renesas_wdt: Add restart handler In-Reply-To: References: <1517423070-24236-1-git-send-email-fabrizio.castro@bp.renesas.com> <1517423070-24236-14-git-send-email-fabrizio.castro@bp.renesas.com> <20180207230309.goxig2irkpxrw5el@katana> Message-ID: <20180212105456.3zejp3j7hfuzyc3c@ninjato> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org > > I used to have this simpler version (back then for the UP case): > > > > +rwdt_start(wdev); > > +rwdt_write(priv, 0xffff, RWTCNT); > > +return 0; > > > > It should still work probably... > > It should still work, but it would be slower, I would stick with the > version I have submitted if you don't mind. Actually, I do mind. Because of code duplication reasons. We have a fix in the works for rwdt_start() and it would be too easy to overlook the same fix will be needed for a restart. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: