From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Tue, 13 Feb 2018 12:16:59 +0530 Subject: [PATCH v4 5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings In-Reply-To: References: <20180209125817.GB3666@localhost> Message-ID: <20180213064659.GD3666@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote: > > > > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma), > > > - pc->sz_ring, &ring->tphys, > > > - GFP_ATOMIC | __GFP_ZERO); > > > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring, > > > + &ring->tphys, GFP_ATOMIC); > > > if (!ring->txd) > > > return -ENOMEM; > > > > > > - memset(ring->txd, 0, pc->sz_ring); > > > > This should be folded back.. > > Sorry, I'm not sure what you mean by "folded back". Since the original patch is also up for review in this series, it doesn't help much to add a change and fix on top in a series. The fix should be folded back into the original commit. IIRC Fengguang's bot also recommends so.. -- ~Vinod