From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH, v3] arm: omap2: timer: fix a kmemleak caused in omap_get_timer_dt
Date: Wed, 14 Feb 2018 08:18:28 -0800 [thread overview]
Message-ID: <20180214161828.GF6364@atomide.com> (raw)
In-Reply-To: <1515646483-24199-1-git-send-email-qi.hou@windriver.com>
* Qi Hou <qi.hou@windriver.com> [180110 20:54]:
> When more than one GP timers are used as kernel system timers and the
> corresponding nodes in device-tree are marked with the same "disabled"
> property, then the "attr" field of the property will be initialized
> more than once as the property being added to sys file system via
> __of_add_property_sysfs().
>
> In __of_add_property_sysfs(), the "name" field of pp->attr.attr is set
> directly to the return value of safe_name(), without taking care of
> whether it's already a valid pointer to a memory block. If it is, its
> old value will always be overwritten by the new one and the memory block
> allocated before will a "ghost", then a kmemleak happened.
>
> That the same "disabled" property being added to different nodes of device
> tree would cause that kind of kmemleak overhead, at leat once.
>
> To fix it, allocate the property dynamically, and delete static one.
Thanks applying into omap-for-v4.16/fixes.
Tony
prev parent reply other threads:[~2018-02-14 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 4:54 [PATCH, v3] arm: omap2: timer: fix a kmemleak caused in omap_get_timer_dt Qi Hou
2018-01-12 20:36 ` Grygorii Strashko
2018-01-12 21:08 ` Tony Lindgren
2018-01-12 21:17 ` Grygorii Strashko
2018-01-12 22:27 ` Keerthy
2018-02-14 16:18 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214161828.GF6364@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).