linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 03/40] KVM: arm64: Avoid storing the vcpu pointer on the stack
Date: Thu, 22 Feb 2018 11:24:18 +0100	[thread overview]
Message-ID: <20180222102418.GK29376@cbox> (raw)
In-Reply-To: <20180222095641.w5isy5jt5a67jocp@kamzik.brq.redhat.com>

On Thu, Feb 22, 2018 at 10:56:41AM +0100, Andrew Jones wrote:
> On Thu, Feb 22, 2018 at 10:10:34AM +0100, Christoffer Dall wrote:
> > On Wed, Feb 21, 2018 at 06:32:00PM +0100, Andrew Jones wrote:
> > > 
> > > Besides my confusion on motivation, it looks good to me
> > > 
> > 
> > In that case, unless there's an argument that the code has become too
> > hard to understand, ...
> >
> 
> On the contrary, I think it's easier to read now than before. I just
> wasn't clear how it all tied together with this series. If its
> combination with other patches enables a speedup, then it certainly
> fits here. I was just comparing mrs+loads vs. a load from stack and

The comparison should be mrs+load, vs. str+load (you save the store on
the stack).

> it seemed it would actually cause a micro-performance-decrease.
> 

Thanks,
-Christoffer

  reply	other threads:[~2018-02-22 10:24 UTC|newest]

Thread overview: 138+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 21:02 [PATCH v4 00/40] Optimize KVM/ARM for VHE systems Christoffer Dall
2018-02-15 21:02 ` [PATCH v4 01/40] KVM: arm/arm64: Avoid vcpu_load for other vcpu ioctls than KVM_RUN Christoffer Dall
2018-02-21  9:32   ` Marc Zyngier
2018-02-21 17:05   ` Andrew Jones
2018-02-15 21:02 ` [PATCH v4 02/40] KVM: arm/arm64: Move vcpu_load call after kvm_vcpu_first_run_init Christoffer Dall
2018-02-21 11:05   ` Marc Zyngier
2018-02-15 21:02 ` [PATCH v4 03/40] KVM: arm64: Avoid storing the vcpu pointer on the stack Christoffer Dall
2018-02-19 15:50   ` Julien Grall
2018-02-22  8:43     ` Christoffer Dall
2018-02-21 11:34   ` Marc Zyngier
2018-02-22  9:02     ` Christoffer Dall
2018-02-22  9:35       ` Marc Zyngier
2018-02-22  9:49       ` Andrew Jones
2018-02-21 17:32   ` Andrew Jones
2018-02-22  9:10     ` Christoffer Dall
2018-02-22  9:56       ` Andrew Jones
2018-02-22 10:24         ` Christoffer Dall [this message]
2018-02-15 21:02 ` [PATCH v4 04/40] KVM: arm64: Rework hyp_panic for VHE and non-VHE Christoffer Dall
2018-02-21 17:32   ` Andrew Jones
2018-02-15 21:02 ` [PATCH v4 05/40] KVM: arm64: Move HCR_INT_OVERRIDE to default HCR_EL2 guest flag Christoffer Dall
2018-02-15 21:02 ` [PATCH v4 06/40] KVM: arm/arm64: Get rid of vcpu->arch.irq_lines Christoffer Dall
2018-02-15 21:02 ` [PATCH v4 07/40] KVM: arm/arm64: Add kvm_vcpu_load_sysregs and kvm_vcpu_put_sysregs Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 08/40] KVM: arm/arm64: Introduce vcpu_el1_is_32bit Christoffer Dall
2018-02-21 12:05   ` Marc Zyngier
2018-02-22  9:11     ` Christoffer Dall
2018-02-21 17:34   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 09/40] KVM: arm64: Move debug dirty flag calculation out of world switch Christoffer Dall
2018-02-21 17:35   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 10/40] KVM: arm64: Slightly improve debug save/restore functions Christoffer Dall
2018-02-21 17:39   ` Andrew Jones
2018-02-21 17:52     ` Marc Zyngier
2018-02-22  8:05       ` Andrew Jones
2018-02-24 18:32       ` Christoffer Dall
2018-02-24 20:16         ` Marc Zyngier
2018-02-15 21:03 ` [PATCH v4 11/40] KVM: arm64: Improve debug register save/restore flow Christoffer Dall
2018-02-21 17:40   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 12/40] KVM: arm64: Factor out fault info population and gic workarounds Christoffer Dall
2018-02-21 17:41   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 13/40] KVM: arm64: Introduce VHE-specific kvm_vcpu_run Christoffer Dall
2018-02-21 17:43   ` Andrew Jones
2018-02-21 18:18     ` Andrew Jones
2018-02-22  9:16       ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 14/40] KVM: arm64: Remove kern_hyp_va() use in VHE switch function Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 15/40] KVM: arm64: Don't deactivate VM on VHE systems Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 16/40] KVM: arm64: Remove noop calls to timer save/restore from VHE switch Christoffer Dall
2018-02-21 17:43   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 17/40] KVM: arm64: Move userspace system registers into separate function Christoffer Dall
2018-02-19 17:21   ` Julien Grall
2018-02-22  9:18     ` Christoffer Dall
2018-02-21 12:21   ` Marc Zyngier
2018-02-15 21:03 ` [PATCH v4 18/40] KVM: arm64: Rewrite sysreg alternatives to static keys Christoffer Dall
2018-02-21 17:44   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 19/40] KVM: arm64: Introduce separate VHE/non-VHE sysreg save/restore functions Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 20/40] KVM: arm/arm64: Remove leftover comment from kvm_vcpu_run_vhe Christoffer Dall
2018-02-21 17:47   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 21/40] KVM: arm64: Unify non-VHE host/guest sysreg save and restore functions Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 22/40] KVM: arm64: Don't save the host ELR_EL2 and SPSR_EL2 on VHE systems Christoffer Dall
2018-02-21 17:49   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 23/40] KVM: arm64: Change 32-bit handling of VM system registers Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 24/40] KVM: arm64: Rewrite system register accessors to read/write functions Christoffer Dall
2018-02-19 18:12   ` Julien Grall
2018-02-22  9:18     ` Christoffer Dall
2018-02-21 13:32   ` Marc Zyngier
2018-02-22  9:22     ` Christoffer Dall
2018-02-22 10:48       ` Marc Zyngier
2018-02-22 11:10         ` Christoffer Dall
2018-02-22 13:26           ` Marc Zyngier
2018-02-22 13:34   ` Andrew Jones
2018-02-22 14:35     ` Christoffer Dall
2018-02-22 15:11   ` Andrew Jones
2018-02-22 15:58     ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 25/40] KVM: arm64: Introduce framework for accessing deferred sysregs Christoffer Dall
2018-02-21 14:16   ` Marc Zyngier
2018-02-22 13:40   ` Andrew Jones
2018-02-22 14:56     ` Christoffer Dall
2018-02-22 17:40   ` Julien Grall
2018-02-15 21:03 ` [PATCH v4 26/40] KVM: arm/arm64: Prepare to handle deferred save/restore of SPSR_EL1 Christoffer Dall
2018-02-21 14:47   ` Marc Zyngier
2018-02-22  9:25     ` Christoffer Dall
2018-02-22 13:49   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 27/40] KVM: arm64: Prepare to handle deferred save/restore of ELR_EL1 Christoffer Dall
2018-02-21 15:08   ` Marc Zyngier
2018-02-22 13:51   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 28/40] KVM: arm64: Defer saving/restoring 64-bit sysregs to vcpu load/put on VHE Christoffer Dall
2018-02-21 15:33   ` Marc Zyngier
2018-02-23 18:05     ` Christoffer Dall
2018-02-22 14:04   ` Andrew Jones
2018-02-22 18:30   ` Julien Grall
2018-02-22 18:31     ` Julien Grall
2018-02-22 19:49       ` Christoffer Dall
2018-02-22 19:48     ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 29/40] KVM: arm64: Prepare to handle deferred save/restore of 32-bit registers Christoffer Dall
2018-02-21 15:44   ` Marc Zyngier
2018-02-22 14:30   ` Andrew Jones
2018-02-23 11:35   ` Julien Grall
2018-02-15 21:03 ` [PATCH v4 30/40] KVM: arm64: Defer saving/restoring 32-bit sysregs to vcpu load/put Christoffer Dall
2018-02-21 16:27   ` Marc Zyngier
2018-02-22 18:15     ` Christoffer Dall
2018-02-22 14:35   ` Andrew Jones
2018-02-22 14:58     ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 31/40] KVM: arm64: Move common VHE/non-VHE trap config in separate functions Christoffer Dall
2018-02-21 17:59   ` Marc Zyngier
2018-02-22 18:17     ` Christoffer Dall
2018-02-25 21:27     ` Christoffer Dall
2018-02-22 15:34   ` Andrew Jones
2018-02-23 14:30   ` Julien Grall
2018-02-23 17:48     ` Christoffer Dall
2018-02-25 21:29     ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 32/40] KVM: arm64: Directly call VHE and non-VHE FPSIMD enabled functions Christoffer Dall
2018-02-21 18:11   ` Marc Zyngier
2018-02-22 15:38   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 33/40] KVM: arm64: Configure c15, PMU, and debug register traps on cpu load/put for VHE Christoffer Dall
2018-02-21 18:20   ` Marc Zyngier
2018-02-22 18:57     ` Christoffer Dall
2018-02-22 15:51   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 34/40] KVM: arm64: Cleanup __activate_traps and __deactive_traps for VHE and non-VHE Christoffer Dall
2018-02-21 18:26   ` Marc Zyngier
2018-02-22 19:04     ` Christoffer Dall
2018-02-22 15:54   ` Andrew Jones
2018-02-15 21:03 ` [PATCH v4 35/40] KVM: arm/arm64: Get rid of vgic_elrsr Christoffer Dall
2018-02-22  9:45   ` Marc Zyngier
2018-02-23 14:44   ` Julien Grall
2018-02-23 17:50     ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 36/40] KVM: arm/arm64: Handle VGICv2 save/restore from the main VGIC code Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 37/40] KVM: arm/arm64: Move arm64-only vgic-v2-sr.c file to arm64 Christoffer Dall
2018-02-22 12:33   ` Marc Zyngier
2018-02-22 14:37     ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 38/40] KVM: arm/arm64: Handle VGICv3 save/restore from the main VGIC code on VHE Christoffer Dall
2018-02-22 12:32   ` Marc Zyngier
2018-02-22 14:42     ` Christoffer Dall
2018-02-22 15:01       ` Marc Zyngier
2018-02-22 16:02         ` Christoffer Dall
2018-02-22 17:21           ` Marc Zyngier
2018-02-22 19:28             ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 39/40] KVM: arm/arm64: Move VGIC APR save/restore to vgic put/load Christoffer Dall
2018-02-22 13:11   ` Marc Zyngier
2018-02-22 14:44     ` Christoffer Dall
2018-02-15 21:03 ` [PATCH v4 40/40] KVM: arm/arm64: Avoid VGICv3 save/restore on VHE with no IRQs Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180222102418.GK29376@cbox \
    --to=christoffer.dall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).