From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf: arm_spe: include linux/vmalloc.h for vmap()
Date: Thu, 22 Feb 2018 12:13:01 +0000 [thread overview]
Message-ID: <20180222121301.GA1591@arm.com> (raw)
In-Reply-To: <20180222114716.1356279-1-arnd@arndb.de>
On Thu, Feb 22, 2018 at 12:47:05PM +0100, Arnd Bergmann wrote:
> On linux-next, I get a build failure in some configurations:
>
> drivers/perf/arm_spe_pmu.c: In function 'arm_spe_pmu_setup_aux':
> drivers/perf/arm_spe_pmu.c:857:14: error: implicit declaration of function 'vmap'; did you mean 'swap'? [-Werror=implicit-function-declaration]
> buf->base = vmap(pglist, nr_pages, VM_MAP, PAGE_KERNEL);
> ^~~~
> swap
> drivers/perf/arm_spe_pmu.c:857:37: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MPX'?
> buf->base = vmap(pglist, nr_pages, VM_MAP, PAGE_KERNEL);
> ^~~~~~
> VM_MPX
> drivers/perf/arm_spe_pmu.c:857:37: note: each undeclared identifier is reported only once for each function it appears in
> drivers/perf/arm_spe_pmu.c: In function 'arm_spe_pmu_free_aux':
> drivers/perf/arm_spe_pmu.c:878:2: error: implicit declaration of function 'vunmap'; did you mean 'iounmap'? [-Werror=implicit-function-declaration]
>
> vmap() is declared in linux/vmalloc.h, so we should include that header file.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks, Arnd. I'll pick this up for 4.17.
Will
next prev parent reply other threads:[~2018-02-22 12:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 11:47 [PATCH] perf: arm_spe: include linux/vmalloc.h for vmap() Arnd Bergmann
2018-02-22 12:13 ` Will Deacon [this message]
2018-02-22 12:26 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180222121301.GA1591@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox