linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin
@ 2018-02-19  7:56 Baruch Siach
  2018-02-19  7:56 ` [PATCH 2/2] ARM: dts: hummingboard: Remove mention of nonexistent node Baruch Siach
  2018-02-24  8:45 ` [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2018-02-19  7:56 UTC (permalink / raw)
  To: linux-arm-kernel

From: Jon Nettleton <jon@solid-run.com>

Fix the USBOTG-ID pin to the correct definition.  The top
USB port stays in device-mode without this change.

Signed-off-by: Jon Nettleton <jon@solid-run.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
index 92583238ca4a..e59b1aeba1d7 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
@@ -242,7 +242,7 @@
 			 * Similar to pinctrl_usbotg_2, but we want it
 			 * pulled down for a fixed host connection.
 			 */
-			fsl,pins = <MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x13059>;
+			fsl,pins = <MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x13059>;
 		};
 
 		pinctrl_hummingboard_usbotg_vbus: hummingboard-usbotg-vbus {
-- 
2.16.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: hummingboard: Remove mention of nonexistent node
  2018-02-19  7:56 [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin Baruch Siach
@ 2018-02-19  7:56 ` Baruch Siach
  2018-02-19 11:05   ` Fabio Estevam
  2018-02-24  8:45 ` [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Baruch Siach @ 2018-02-19  7:56 UTC (permalink / raw)
  To: linux-arm-kernel

There is no pinctrl_usbotg_2 node in current Hummingboard dts files.
Drop reference to that.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 arch/arm/boot/dts/imx6qdl-hummingboard.dtsi  | 3 +--
 arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
index e59b1aeba1d7..d1f8fd708e13 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
@@ -239,8 +239,7 @@
 
 		pinctrl_hummingboard_usbotg_id: hummingboard-usbotg-id {
 			/*
-			 * Similar to pinctrl_usbotg_2, but we want it
-			 * pulled down for a fixed host connection.
+			 * We want it pulled down for a fixed host connection.
 			 */
 			fsl,pins = <MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x13059>;
 		};
diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
index dffbc92e0023..194d152d8f4b 100644
--- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
@@ -409,8 +409,7 @@
 
 		pinctrl_hummingboard2_usbotg_id: hummingboard2-usbotg-id {
 			/*
-			 * Similar to pinctrl_usbotg_2, but we want it
-			 * pulled down for a fixed host connection.
+			 * We want it pulled down for a fixed host connection.
 			 */
 			fsl,pins = <MX6QDL_PAD_GPIO_1__USB_OTG_ID 0x13059>;
 		};
-- 
2.16.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: hummingboard: Remove mention of nonexistent node
  2018-02-19  7:56 ` [PATCH 2/2] ARM: dts: hummingboard: Remove mention of nonexistent node Baruch Siach
@ 2018-02-19 11:05   ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2018-02-19 11:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Feb 19, 2018 at 4:56 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> There is no pinctrl_usbotg_2 node in current Hummingboard dts files.
> Drop reference to that.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin
  2018-02-19  7:56 [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin Baruch Siach
  2018-02-19  7:56 ` [PATCH 2/2] ARM: dts: hummingboard: Remove mention of nonexistent node Baruch Siach
@ 2018-02-24  8:45 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-02-24  8:45 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Feb 19, 2018 at 09:56:44AM +0200, Baruch Siach wrote:
> From: Jon Nettleton <jon@solid-run.com>
> 
> Fix the USBOTG-ID pin to the correct definition.  The top
> USB port stays in device-mode without this change.
> 
> Signed-off-by: Jon Nettleton <jon@solid-run.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied both, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-02-24  8:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-19  7:56 [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin Baruch Siach
2018-02-19  7:56 ` [PATCH 2/2] ARM: dts: hummingboard: Remove mention of nonexistent node Baruch Siach
2018-02-19 11:05   ` Fabio Estevam
2018-02-24  8:45 ` [PATCH 1/2] ARM: dts: imx6qdl-hummingboard: fix USBOTG-ID pin Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).